Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Media Queries to Create Account modals for Wallet Panel V2 #31822

Closed
Douglashdaniel opened this issue Jul 24, 2023 · 1 comment · Fixed by brave/brave-core#19406
Closed

Add Media Queries to Create Account modals for Wallet Panel V2 #31822

Douglashdaniel opened this issue Jul 24, 2023 · 1 comment · Fixed by brave/brave-core#19406
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.58.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to add Media Queries to the Create Account modals to look good in the Wallet Panel

Screen.Recording.5.mov
@Douglashdaniel Douglashdaniel added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 24, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jul 24, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jul 24, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel changed the title Add Media Queries Create Account modals for Wallet Panel V2 Add Media Queries to Create Account modals for Wallet Panel V2 Jul 24, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 24, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2023

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Linux
31822.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)
31822.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (arm64)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS macOS Version 13.4.1 (c) (Build 22F770820d)
31822.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Responsive Create Account Modals for Panel brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds