Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import JSON file from panel or connect HW wallet #32748

Closed
srirambv opened this issue Sep 5, 2023 · 1 comment
Closed

Unable to import JSON file from panel or connect HW wallet #32748

srirambv opened this issue Sep 5, 2023 · 1 comment
Labels

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2023

Description

Unable to import JSON file from panel or connect HW wallet

Steps to Reproduce

JSON Import

  1. Enable V2 panel flag
  2. Select accounts tab
  3. Select menu and click on Import account
  4. Select Eth and select JSON file import
  5. Click on Choose file
  6. File explorer is not loaded

Hardware Wallet Import

  1. Enable V2 panel flag
  2. Select accounts tab
  3. Connect Ledger and select menu and click on Connect a hardware wallet
  4. Select ETH and select Ledger
  5. Click on Authorize, doesn't show up the webconnect modal
  6. Connect Trezor and select Trezor
  7. Doesn't load the Trezor connect approval screen

Actual result:

Import.JSON.and.HW.wallet.mov

Expected result:

Should be able to open import file window and able to connect hardware wallets via panel

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? No, it opens the wallet page for import

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @josheleonard

@Douglashdaniel
Copy link

Both of these are in 1.59.x which is also where Enable Panel V2 by Default: brave/brave-core#19751 landed, so these do not need to be fixed in 1.58.x Beta

Closing as Duplicate and Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants