Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Enable Panel V2 by Default #19751

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Enables the Panel V2 feature by default

Resolves brave/brave-browser#32352

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to brave://flags and make sure that Enable Panel v2 is Default (Enabled)
  2. Open the Wallet Panel, it should be the new V2 design

Screenshot 3

Screenshot 4

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enable-panel-v2-by-default branch 2 times, most recently from 522b2ae to 24f6fb0 Compare August 18, 2023 04:15
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner August 18, 2023 04:15
@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enable-panel-v2-by-default branch from 24f6fb0 to a5292f2 Compare August 18, 2023 19:04
@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-enable-panel-v2-by-default branch from a5292f2 to 7172da0 Compare August 21, 2023 12:41
@Douglashdaniel Douglashdaniel merged commit fc6f76b into master Aug 21, 2023
13 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-enable-panel-v2-by-default branch August 21, 2023 15:06
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 21, 2023
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Panel V2 by Default
3 participants