Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Expand to Connect Hardware Wallet #19882

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Will now expand to the Desktop View when a users clicks on Connect hardware wallet in the Panel
Temp fix until brave/brave-browser#31837 is implemented.

Resolves brave/brave-browser#32524

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet Panel and navigate to the Accounts tab
  2. Click on the More Menu and then click on Connect hardware wallet
  3. It should expand to the Desktop View
Screen.Recording.15.mov

@Douglashdaniel Douglashdaniel self-assigned this Aug 25, 2023
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner August 25, 2023 15:01
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Aug 25, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Douglashdaniel Douglashdaniel merged commit a341aef into master Aug 28, 2023
14 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-expand-to-connect-hardware-wallet branch August 28, 2023 15:38
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand to Desktop View to Connect Hardware Wallet in Panel
3 participants