Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand to Desktop View to Connect Hardware Wallet in Panel #32524

Closed
Douglashdaniel opened this issue Aug 25, 2023 · 1 comment · Fixed by brave/brave-core#19882
Closed

Expand to Desktop View to Connect Hardware Wallet in Panel #32524

Douglashdaniel opened this issue Aug 25, 2023 · 1 comment · Fixed by brave/brave-core#19882
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.59.x - Release

Comments

@Douglashdaniel
Copy link

Description

Until #31837 is implemented, we need to expand to the Desktop View to Connect Hardware Wallets from the Panel
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 25, 2023
@Douglashdaniel Douglashdaniel self-assigned this Aug 25, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Aug 25, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 28, 2023
@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2023

Verification passed on

Brave 1.59.112 Chromium: 118.0.5993.54 (Official Build) (64-bit)
Revision 967f25f295938c64c24e2e6a1790470668757655
OS Windows 11 Version 22H2 (Build 22621.2283)
  • Verified steps from brave/brave-core#19882
  • Verified Connect Hardware Wallet from panel opens expanded desktop view
32524.mp4

Verification passed on

Brave 1.59.112 Chromium: 118.0.5993.54 (Official Build) (64-bit)
Revision 967f25f295938c64c24e2e6a1790470668757655
OS Linux
  • Verified steps from brave/brave-core#19882
  • Verified Connect Hardware Wallet from panel opens expanded desktop view
32524.mp4

Verification passed on

Brave 1.59.112 Chromium: 118.0.5993.54 (Official Build) (arm64)
Revision 967f25f295938c64c24e2e6a1790470668757655
OS macOS Version 14.0 (Build 23A344)
  • Verified steps from brave/brave-core#19882
  • Verified Connect Hardware Wallet from panel opens expanded desktop view
32524.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Expand to Connect Hardware Wallet brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds