Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to dismiss end of support notice message for macOS #32129

Closed
rebron opened this issue Aug 8, 2023 · 7 comments · Fixed by brave/brave-core#19618
Closed

Provide option to dismiss end of support notice message for macOS #32129

rebron opened this issue Aug 8, 2023 · 7 comments · Fixed by brave/brave-core#19618

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 8, 2023

Description

Follow-up of #27122 but for macOS. Needed to support 1.57.x which is the last supported version for macOS 10.13 and 10.14.

Expected result:

Same as ability to dismiss infobar as we did for Windows 7 or 8 with confirmation dialog.
#27649

Infobar
259275473-9d19e3c9-8255-4641-99c6-91859e0254b7

Learn more link should point to:
https://support.brave.com/hc/en-us/articles/18347246446733-Changes-to-macOS-desktop-browser-requirements

Confirmation dialog
image_720-1

Brave version (brave://version info)

Version/Channel Information:

n/a
  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Need to add IS_MAC to https://github.com/brave/brave-core/blob/master/chromium_src/chrome/browser/ui/startup/infobar_utils.cc#L26

Additional strings for:
#27122 (comment)

@mkarolin
Copy link
Contributor

mkarolin commented Aug 9, 2023

Chromium's implementation without the dismiss option:

image

@mkarolin
Copy link
Contributor

mkarolin commented Aug 9, 2023

With dismiss option:

image

Dismissing with checkbox checked:

image

@kjozwiak
Copy link
Member

Quick note to @brave/qa-team, the above won't be translated as it missed translations earlier in the week. We'll need to get the above translated in 1.58.x. @mkarolin assuming this will be done automatically or should we create a new issue just in case?

@kjozwiak
Copy link
Member

kjozwiak commented Aug 15, 2023

The above requires 1.57.47 or higher for 1.57.x verification 👍QA can use brave/brave-core#19618 (comment) as the template for STR/Cases to run through.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 15, 2023

Verified with

10.14.x Mojave - PASSED
Brave	1.57.47 Chromium: 116.0.5845.96 (Official Build) (x86_64) 
Revision	180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS	macOS Version 10.14.6 (Build 18G103)
  • ensured that the correct OS is being listed via the infobar
  • ensured that the Learn more link worked as expected and opened the correct support page
  • ensured that the infobar only appears once per session once it's dismissed via X
  • ensured that the infobar always appears after re-launch if the user hasn't checked off Don't show again
  • ensured that the infobar always appear after re-launch if the user checked off Don't show again but never confirmed
  • ensured that the infobar always appears after re-launch when user checked off Don't show again but cancelled confirmation
  • ensured that the infobar doesn't re-appear again once the user clicks on OK and confirms
  • ensured that the infobar doesn't re-appear once permanently closed via Guest, PB & Tor windows
Example Example Example Example
1 2 3 4
10.13.x High Sierra - PASSED
Brave	1.57.47 Chromium: 116.0.5845.96 (Official Build) (x86_64) 
Revision	180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS	macOS Version 10.13.6 (Build 17G66)
  • ensured that the correct OS is being listed via the infobar
  • ensured that the Learn more link worked as expected and opened the correct support page
  • ensured that the infobar only appears once per session once it's dismissed via X
  • ensured that the infobar always appears after re-launch if the user hasn't checked off Don't show again
  • ensured that the infobar always appear after re-launch if the user checked off Don't show again but never confirmed
  • ensured that the infobar always appears after re-launch when user checked off Don't show again but cancelled confirmation
  • ensured that the infobar doesn't re-appear again once the user clicks on OK and confirms
  • ensured that the infobar doesn't re-appear once permanently closed via Guest, PB & Tor windows
Example Example Example Example
1 2 3 4
10.15.x Catalina - PASSED
Brave	1.57.47 Chromium: 116.0.5845.96 (Official Build) (x86_64) 
Revision	180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS	macOS Version 10.15.7 (Build 19H1824)

Ensured that the infobar doesn't appear on newer macOS versions. Used 1.57.47 Chromium: 116.0.5845.96 on macOS Catalina 10.15.7 and ensured that the infobar doesn't appear as per the following:

Example Example
1 2

@mkarolin
Copy link
Contributor

mkarolin commented Aug 15, 2023

Quick note to @brave/qa-team, the above won't be translated as it missed translations earlier in the week. We'll need to get the above translated in 1.58.x. @mkarolin assuming this will be done automatically or should we create a new issue just in case?

It will get translated automatically with 1.58.x, although, people with 10.13/10.14 won't be able to upgrade to 1.58.x.

@mkarolin
Copy link
Contributor

@kjozwiak created #32259. Not sure if there's enough time to get it into the release, but could go into a HF or CR bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants