-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide option to dismiss end of support notice message for macOS #32129
Comments
Quick note to @brave/qa-team, the above won't be translated as it missed translations earlier in the week. We'll need to get the above translated in |
The above requires |
It will get translated automatically with |
Description
Follow-up of #27122 but for macOS. Needed to support 1.57.x which is the last supported version for macOS 10.13 and 10.14.
Expected result:
Same as ability to dismiss infobar as we did for Windows 7 or 8 with confirmation dialog.
#27649
Infobar
Learn more link should point to:
https://support.brave.com/hc/en-us/articles/18347246446733-Changes-to-macOS-desktop-browser-requirements
Confirmation dialog
Brave version (brave://version info)
Version/Channel Information:
n/aOther Additional Information:
Miscellaneous Information:
Need to add IS_MAC to https://github.com/brave/brave-core/blob/master/chromium_src/chrome/browser/ui/startup/infobar_utils.cc#L26
Additional strings for:
#27122 (comment)
The text was updated successfully, but these errors were encountered: