Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading effect in portfolio asset view when balances are being fetched #32141

Closed
onyb opened this issue Aug 9, 2023 · 1 comment · Fixed by brave/brave-core#22409
Closed

Add loading effect in portfolio asset view when balances are being fetched #32141

onyb opened this issue Aug 9, 2023 · 1 comment · Fixed by brave/brave-core#22409
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@onyb
Copy link
Member

onyb commented Aug 9, 2023

When balances are being fetched, the highlighted section should display a loading effect.

Screenshot 2023-08-09 at 12 26 33
@onyb onyb added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 9, 2023
@onyb onyb added this to Web3 Aug 9, 2023
@Douglashdaniel Douglashdaniel self-assigned this Aug 10, 2023
@Douglashdaniel Douglashdaniel moved this to Backlog in Web3 Aug 10, 2023
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Feb 29, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Feb 29, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 1, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 1, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit)
Revision 5d9143e1a0812c53bdc27fd5384591254306a88c
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from brave/brave-core#22409
  • Verified loading state indicator is shown on portfolio asset view when balances are being fetched
32141.mp4

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Add Portfolio Asset Loading Skeletons brave/brave-core
4 participants
@onyb @srirambv @Douglashdaniel @brave-builds