Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Add Portfolio Asset Loading Skeletons #22409

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Adds Loading Skeletons to the Accounts List on the Portfolio Asset page

Resolves brave/brave-browser#32141

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio page and view an Assets details
  2. There should be a Loading Skeleton until balances are loaded.
Screen.Recording.mov

@Douglashdaniel Douglashdaniel self-assigned this Feb 29, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 29, 2024 23:40
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Feb 29, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the fix-wallet-portfolio-asset-loading-skeletons branch from 3e271c7 to 574bfbc Compare March 1, 2024 02:16
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit ad6f4ff into master Mar 1, 2024
19 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-portfolio-asset-loading-skeletons branch March 1, 2024 15:41
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading effect in portfolio asset view when balances are being fetched
3 participants