Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rounded corners to all panels from the navigation bar #32150

Closed
9 tasks done
rebron opened this issue Aug 9, 2023 · 3 comments · Fixed by brave/brave-core#19795
Closed
9 tasks done

Add rounded corners to all panels from the navigation bar #32150

rebron opened this issue Aug 9, 2023 · 3 comments · Fixed by brave/brave-core#19795
Assignees
@zenparsing
Labels
design A design change, especially one which needs input from the design team feature/url-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 9, 2023 •
edited
Loading

Description

Follow-up to #28622 which added rounded corners to the Brave Rewards panel.

  • Bookmarks panel
  • In address bar: Tune/site settings panel
  • In address bar: PWA menu
  • In address bar: Brave News feeds menu
  • In address bar: Share menu
  • Shields panel
  • Extensions panel
  • Downloads panel
  • Wallet 2.0 panel

Expected result:

[placeholder for Figma designs}

Reproduces how often:

n/a

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron rebron added OS/Desktop feature/url-bar design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Aug 9, 2023
@zenparsing zenparsing self-assigned this Aug 9, 2023
@zenparsing zenparsing mentioned this issue Aug 21, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 28, 2023
@rebron rebron mentioned this issue Sep 15, 2023
Closed
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 18, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 18, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.59.90 Chromium: 117.0.5938.88 (Official Build) beta (64-bit)
-- | --
Revision | 5272112c86588e44ec7c0b766c318cddccbced85
OS | Windows 11 Version 22H2 (Build 22621.2283)

Install 1.59.90
Launched Brave
opened following panels in the navigation bar

  • Bookmarks panel - [✓]
  • In address bar: Tune/site settings panel- [✓]
  • In address bar: PWA menu- [✓]
  • In address bar: Brave News feeds menu - [✓]
  • In address bar: Share menu- [✓]
  • Shields panel - [✓]
  • Extensions panel- [✓]
  • Downloads panel- [✓]
  • Wallet 2.0 panel - [✓]

Confirmed rounded corners are shown for all the feature panels

Bookmarks panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

In address bar: Tune/site settings panel

1.58.127 1.59.90(Light) 1.59.90(Dark)

image|image|image

In address bar: PWA menu

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

In address bar: Brave News feeds menu

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

In address bar: Share menu

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

Shields panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

VPN Panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

Extensions panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

Downloads panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

Wallet 2.0 panel

1.58.127 1.59.90(Light) 1.59.90(Dark)
image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 18, 2023
@MadhaviSeelam MadhaviSeelam mentioned this issue Sep 18, 2023
Closed
@stephendonner
Copy link

stephendonner commented Sep 18, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.59.92 Chromium: 117.0.5938.88 (Official Build) beta (x86_64)
-- | --
Revision | cf6e2f14e9e5a022c570aaa24e8c7ff7e4a541e5
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.59.92
  2. launched Brave
  3. opened the following panels in the navigation bar
  • Bookmarks panel - [✓]
  • In address bar: Tune/site settings panel - [✓]
  • In address bar: PWA menu - [✓]
  • In address bar: Brave News feeds menu - [✓]
  • In address bar: Share menu - [✓]
  • Shields panel - [✓]
  • Extensions panel - [✓]
  • Downloads panel - [✓]
  • Wallet 2.0 panel - [✓]

Confirmed rounded corners are shown for all the feature panels

Bookmarks panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 20 07 PM Screen Shot 2023-09-18 at 4 22 01 PM Screen Shot 2023-09-18 at 4 22 24 PM

In address bar: Tune/site settings panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 27 56 PM Screen Shot 2023-09-18 at 4 28 49 PM Screen Shot 2023-09-18 at 4 28 29 PM

In address bar: PWA menu - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 33 29 PM Screen Shot 2023-09-18 at 4 34 43 PM Screen Shot 2023-09-18 at 4 35 07 PM

In address bar: Brave News feeds menu - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 37 46 PM Screen Shot 2023-09-18 at 4 39 32 PM Screen Shot 2023-09-18 at 4 39 08 PM

In address bar: Share menu - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 5 19 02 PM Screen Shot 2023-09-18 at 5 20 28 PM Screen Shot 2023-09-18 at 5 22 27 PM

Shields panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 5 14 09 PM Screen Shot 2023-09-18 at 5 12 07 PM Screen Shot 2023-09-18 at 5 12 58 PM

VPN Panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 5 04 24 PM Screen Shot 2023-09-18 at 5 05 47 PM Screen Shot 2023-09-18 at 5 05 18 PM

Extensions panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 54 50 PM Screen Shot 2023-09-18 at 4 58 27 PM Screen Shot 2023-09-18 at 4 58 52 PM

Downloads panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 48 21 PM Screen Shot 2023-09-18 at 4 49 38 PM Screen Shot 2023-09-18 at 4 49 19 PM

Wallet 2.0 panel - PASSED

1.58.127 1.59.92 (Light) 1.59.92 (Dark)
Screen Shot 2023-09-18 at 4 41 57 PM Screen Shot 2023-09-18 at 4 43 37 PM Screen Shot 2023-09-18 at 4 44 01 PM

@MadhaviSeelam MadhaviSeelam mentioned this issue Sep 19, 2023
Open
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 2, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Oct 2, 2023 •
edited
Loading

Verified with

Brave	1.59.107 Chromium: 117.0.5938.140 (Official Build) beta (64-bit) 
Revision	5bbd53ed3e41461e15555b7ce0490464656b236f
OS	Linux

Steps:

  1. installed 1.59.x
  2. launched Brave
  3. opened the following panels in the navigation bar
  • Bookmarks panel - [✓]
  • In address bar: Tune/site settings panel - [✓]
  • In address bar: PWA menu - [✓]
  • In address bar: Brave News feeds menu - [✓]
  • In address bar: Share menu - [✓]
  • Shields panel - [✓]
  • Extensions panel - [✓]
  • Downloads panel - [✓]
  • Wallet 2.0 panel - [✓]

Note - Encountered #33124 while testing.

Confirmed rounded corners are shown for all the feature panels

Bookmarks panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

In address bar: Tune/site settings panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

In address bar: PWA menu - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

In address bar: Brave News feeds menu - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

In address bar: Share menu - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Shields panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3
4 5 6

VPN Panel - N/A

No VPN on Linux, so VPN panel is N/A

Extensions panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Downloads panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Wallet 2.0 panel - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Find in Page - PASSED

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Search Tabs - PASSED

Horizontal Tabs

1.58.135 1.59.x (Light) 1.59.x (Dark)
1 2 3

Vertical Tabs

1.58.135 1.59.x (Light) 1.59.x (Dark)
4 5 6

@LaurenWags LaurenWags added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 3, 2023
@LaurenWags LaurenWags mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
design A design change, especially one which needs input from the design team feature/url-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Add rounded corners to navigation bar panels brave/brave-core
6 participants
@stephendonner @rebron @zenparsing @LaurenWags @brave-builds @MadhaviSeelam