Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rounded corners on the Brave Rewards dropdown panel #28622

Closed
Miyayes opened this issue Feb 20, 2023 · 6 comments · Fixed by brave/brave-core#18348
Closed

Implement rounded corners on the Brave Rewards dropdown panel #28622

Miyayes opened this issue Feb 20, 2023 · 6 comments · Fixed by brave/brave-core#18348
Assignees
@mkarolin
Labels
feature/rewards OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 20, 2023

@Miyayes Miyayes added polish Nice to have — usually related to front-end/visual tasks feature/rewards OS/Desktop labels Feb 20, 2023
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 22, 2023
@Miyayes Miyayes assigned mkarolin and unassigned emerick and zenparsing Apr 15, 2023
mkarolin added a commit to brave/brave-core that referenced this issue May 3, 2023
@mkarolin
Adds rounded corners to Rewards panel.
0f061f2 
Fixes brave/brave-browser#28622
@mkarolin mkarolin mentioned this issue May 3, 2023
Merged
25 tasks
@mkarolin mkarolin added this to the 1.53.x - Nightly milestone May 5, 2023
@mkarolin
Copy link
Contributor

mkarolin commented May 5, 2023

Test Plan:

  1. Start Brave
  2. Click on the Rewards button and verify that the panel has rounded corners (all 4).

@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 18, 2023
Closed
@LaurenWags
Copy link
Member

Added QA/Test-All-Platforms as we have seen OS specific differences with the rounded corners previously.

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 2, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 2, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.53.76 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 10 Version 22H2 (Build 19045.2965)

non-connected users

  • Confirm that the BR panel corners are rounded in non-connected users state
  • Confirm that the BR panel corners are rounded for cross custodian creators
  • Confirm that the BR panel corners are rounded for unverified creators
Example Example
image image

Connected users

  • Confirm that the BR panel corners are rounded in connected users state
  • Confirm that the BR panel corners are rounded for cross custodian creators
  • Confirm that the BR panel corners are rounded for unverified creators
Example Example
image image
image image
image image

Grandfathered connected state upgrade

  • Install 1.47.121 beta build
  • Connect custodian
  • Upgrade the profile to 1.53.x beta build
  • Ensured that the BR panel corners are rounded in grandfathered connected state
1.47.x 1.47.x 1.47.x 1.47.x 1.47.x
image image image image image
1.53.x 1.53.x 1.53.x 1.53.x 1.53.x
image image image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 5, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 8, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.53.83 Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Windows 11 Version 22H2 (Build 22621.1702)

non-connected users

  • Confirm that the BR panel corners are rounded in non-connected users state
Example Example
image image

Connected users

Confirm that the BR panel corners are rounded in connected users state

example example
image image
image image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 8, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jun 8, 2023 •
edited
Loading

Verified with

Brave | 1.53.85 Chromium: 114.0.5735.110 (Official Build) beta (x86_64)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | macOS Version 13.4 (Build 22F66)

non-connected users

  • Confirm that the BR panel corners are rounded in non-connected users state
Example Example
1 2

Connected users

  • Confirm that the BR panel corners are rounded in connected users state
Example Example
1 2
3 4

Grandfathered unconnected state

  • Have a profile on 1.52.x that is in grandfathered unconnected state (no custodian connected)
  • Upgrade the profile to 1.53.x beta build
  • Ensured that the BR panel corners are rounded in grandfathered unconnected state
1.52.x 1.52.x 1.53.x 1.53.x
1 2 3 4
5 6 7 8

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 8, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jun 9, 2023 •
edited
Loading

Verified with

Brave	1.53.87 Chromium: 114.0.5735.110 (Official Build) beta (64-bit) 
Revision	1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS	Linux

non-connected users

  • Confirm that the BR panel corners are rounded in non-connected users state
Example Example
1 2

Connected users

  • Confirm that the BR panel corners are rounded in connected users state
Example Example
1 2
3 4

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 9, 2023
@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
@rebron rebron mentioned this issue Aug 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/rewards OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Adds rounded corners to Rewards panel. brave/brave-core
7 participants
@emerick @zenparsing @Miyayes @LaurenWags @GeetaSarvadnya @mkarolin @MadhaviSeelam