Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more features Brave disabled from Devtools #32187

Closed
pes10k opened this issue Aug 11, 2023 · 1 comment · Fixed by brave/brave-core#19649
Closed

Remove more features Brave disabled from Devtools #32187

pes10k opened this issue Aug 11, 2023 · 1 comment · Fixed by brave/brave-core#19649
Assignees
@sangwoo108
Labels
feature/dev-tools OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS-arm64 QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Aug 11, 2023

The DevTools UI still includes a bunch of features Brave disables from upstream, which is confusing and wasted UI space.

I'd be great to remove all of these items from the DevTools UI

  • interest groups
  • shared storage
  • Background Fetch/Sync
  • Periodic Background Sync
  • Reporting API

Separately, seems like something upstream might be interested in taking too (so that their UI matches their FeatureFlag state)

Screenshot 2023-08-10 at 18 13 15
@sangwoo108 sangwoo108 self-assigned this Aug 11, 2023
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Aug 11, 2023
@sangwoo108 sangwoo108 mentioned this issue Aug 11, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 21, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 27, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Sep 27, 2023 •
edited
Loading

Verified with

Brave | 1.59.100 Chromium: 117.0.5938.92 (Official Build) beta (arm64)
-- | --
Revision | 3243fffc43431ab8677e8139859670b4cd2df843
OS | macOS Version 14.0 (Build 23A344)

Compared 1.58.131 to 1.59.100.
Confirmed the following items are removed from the Application tab of DevTools as per the test plan from brave/brave-core#19649 (comment)

  • interest groups
  • shared storage
  • Background Fetch/Sync
  • Periodic Background Sync
  • Reporting API
1.58.131 1.59.100
1 2

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 27, 2023
@LaurenWags LaurenWags mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/dev-tools OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Hide more items from Devtools > Application tab brave/brave-core
5 participants
@pes10k @sangwoo108 @rebron @LaurenWags @brave-builds