Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide more items from Devtools > Application tab #19649

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Aug 11, 2023

Hide following items that we've disabled

  • interest groups
  • shared storage
  • Background Fetch/Sync
  • Periodic Background Sync
  • Reporting API

In order to keep the patch file single line, dynamically removes elements instead of commenting out the code.

Before:
Screenshot 2023-08-10 at 18 13 15

After:
image

Resolves brave/brave-browser#32187

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open devtools and go to the Application tab
  • The items noted above shouldn't be on the left side panel.

Hide following items that we've disabled

* interest groups
* shared storage
* Background Fetch/Sync
* Periodic Background Sync
* Reporting API

In order to keep the patch file single line, dynamically removes elements
instead of commenting out the code.
@sangwoo108 sangwoo108 marked this pull request as ready for review August 11, 2023 03:31
@sangwoo108 sangwoo108 requested a review from a team as a code owner August 11, 2023 03:31
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! (Though please keep in mind I’m not a great code reviewer)

@sangwoo108 sangwoo108 merged commit fe13e80 into master Aug 21, 2023
18 checks passed
@sangwoo108 sangwoo108 deleted the sko/devtools branch August 21, 2023 23:54
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove more features Brave disabled from Devtools
3 participants