NTP always shows the same background image

[A-t-s-u-s-h-i]

Description

https://community.brave.com/t/topic/500776

NTP shows same image no matter how many times they reload NTP.

Steps to Reproduce

1. launch Brave(desktop)
2. Show NTP
3. Repeat reloading

Actual result:

The same background image shows

Expected result:

Shows other background images randomly

Reproduces how often:

Easily reproduced(only on specific devices)

Brave version (brave://version info)

v1.57.47
Windows10

[A-t-s-u-s-h-i]

Now same issue happens on my device. The issue happens only on a specific browser profile. NTP changes randomly on other profiles.

Brave 1.57.53
NTP Background Images - version: 1.0.11
Sponsored images enabled

2023-08-24.11.32.55.mov

[kjozwiak]

The above requires 1.58.119 or higher for 1.58.x verification 👍

[LaurenWags]

Verified with

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 13.5.2 (Build 22G91)

Used "Manual Test" steps from brave/brave-core#19896 (comment) and 1.57.62 Chromium: 116.0.5845.180 to reproduce the issue.

Upgrade Profile - PASSED

1. Launch browser 1.57.62 and current region has SI campaign (used US)
2. Open NTP reload multiple times till SI is shown and reload three times.
3. With this condition, NTP SI will be shown at next NTP reloading or opening
4. Close all NTP to prevent opening NTP at next startup (Having non-NTP tab is fine before closing window, my non-NTP tab was brave://components)
5. Shutdown browser and change OS to another region that doesn't have SI campaign (I used Japan)
6. Launch Browser and make sure there is no NTP tab
7. Load brave://components (if not already open) in existing tab and update NTP SI components to get empty campaign
8. Open NTP and reload
9. Confirmed same NTP background image is shown whenever reloading
10. Upgraded profile to 1.58.120
11. Opened NTP and refreshed several times
12. Confirmed different NTP background images are shown whenever reloading

Step 4	Step 5	Step 7	Step 9	Step 9	Step 9	Step 10	Step 10	Step 12	Step 12	Step 12

Clean Profile - PASSED

1. Launch browser 1.58.120 and current region has SI campaign (used US)
2. Open NTP reload multiple times till SI is shown and reload three times.
3. With this condition, NTP SI will be shown at next NTP reloading or opening
4. Close all NTP to prevent opening NTP at next startup (Having non-NTP tab is fine before closing window, my non-NTP tab was brave://components)
5. Shutdown browser and change OS to another region that doesn't have SI campaign (I used Japan)
6. Launch Browser and make sure there is no NTP tab
7. Load brave://components (if not already open) in existing tab and update NTP SI components to get empty campaign
8. Open NTP and reload
9. Confirmed different NTP background images are shown whenever reloading

Step 4	Step 5	Step 7	Step 9	Step 9	Step 9