Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wayback Machine info bar Don't show again button to a checkbox #32404

Closed
rebron opened this issue Aug 20, 2023 · 2 comments · Fixed by brave/brave-core#19876
Closed

Update Wayback Machine info bar Don't show again button to a checkbox #32404

rebron opened this issue Aug 20, 2023 · 2 comments · Fixed by brave/brave-core#19876

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 20, 2023

Description

The current Wayback Machine info bar uses a button for Don't show again.
We should use a checkbox for consistency and minimize mis-clicks if a user meant to Close the info bar instead of Don't show again

Steps to Reproduce

  1. Visit a page that will trigger the Wayback machine prompt rebron.org/test.html
  2. Notice Wayback machine info bar.
  3. Should be a Don't show again checkbox.

Actual result:

Screenshot 2023-08-20 at 1 40 19 PM

Example of checkbox in the info bar re: OS notification
259514955-cc0af0e5-749f-4ac2-ab1a-eb8c181ff231

Expected result:

Use checkbox instead of button.

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@simonhong
Copy link
Member

Working on this.

simonhong added a commit to brave/brave-core that referenced this issue Aug 25, 2023
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 26, 2023
@rebron rebron changed the title Update Wayback Machine info bar Don't show again button to checkbox Update Wayback Machine info bar Don't show again button to a checkbox Aug 31, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 28, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2023

Verified with

Brave | 1.59.102 Chromium: 117.0.5938.140 (Official Build) beta (arm64)
-- | --
Revision | 11284b6d5d51252fe1a6fb6b5cba35ef98982357
OS | macOS Version 14.0 (Build 23A344)

Verified STR from description.
Confirmed checkbox shows instead of button.
Confirmed for both light and dark themes.
Confirmed I was able to click the checkbox.
Confirmed after clicking the "Don't ask me again" checkbox and reloading the test page, the Wayback Machine info bar did not display.
Confirmed visiting another page, ex. brave.com/bo did not show Wayback Machine info bar.
Confirmed able to re-enable the Wayback Machine setting under brave://settings/braveHelpTips and the Wayback Machine info bar came back.
Confirmed when the setting under brave://settings/braveHelpTips is re-enabled, a checkbox is shown, not a button.

Light Dark Checked
Screenshot 2023-09-28 at 1 21 36 PM Screenshot 2023-09-28 at 1 21 49 PM Screenshot 2023-09-28 at 1 22 17 PM

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment