Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text in URL bar is not highlighted when focused [CR118] #33333

Closed
Uni-verse opened this issue Sep 29, 2023 · 2 comments · Fixed by brave/brave-core#20374
Closed

Text in URL bar is not highlighted when focused [CR118] #33333

Uni-verse opened this issue Sep 29, 2023 · 2 comments · Fixed by brave/brave-core#20374
Assignees
@samartnik
Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes regression release-notes/exclude
Milestone
1.59.x - Release

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 29, 2023 •
edited
Loading

Description

Text in URL bar is not highlighted when focused, regression in Chromium 118

Steps to reproduce

  1. Open website
  2. Tap on the URL bar
  3. Observe

Actual result

Screenshot 2023-09-29 at 11 52 19 AM

Expected result

Screenshot 2023-09-29 at 11 55 41 AM

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? TBD
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 13

Brave version

1.60.64, Chromium 118.0.5593.21
@Uni-verse Uni-verse added bug QA/Yes release-notes/exclude regression OS/Android Fixes related to Android browser functionality labels Sep 29, 2023
@Uni-verse Uni-verse mentioned this issue Sep 29, 2023
Closed
@samartnik samartnik self-assigned this Oct 3, 2023
@samartnik samartnik mentioned this issue Oct 3, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 4, 2023
This was referenced Oct 4, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2023

The above requires 1.59.112 or higher for 1.59.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 5, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 5, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.59.112
Chromium: 118.0.5993.54 (Official Build) (64-bit) 
Revision: 967f25f295938c64c24e2e6a1790470668757655

STEPS:
Followed the steps from #33333 (comment)

ACTUAL RESULTS:

  • Verified that the text in the URL bar is highlighted when tapping on it
2023-10-05_10-31-54.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Fix for text in URL bar not highlighted when focused brave/brave-core
5 participants
@kjozwiak @Uni-verse @samartnik @brave-builds @hffvld