Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no icon for "Don't allow sites to connect to HID devices" #33380

Closed
LaurenWags opened this issue Oct 3, 2023 · 6 comments · Fixed by brave/brave-core#20449
Closed

no icon for "Don't allow sites to connect to HID devices" #33380

LaurenWags opened this issue Oct 3, 2023 · 6 comments · Fixed by brave/brave-core#20449

Comments

@LaurenWags
Copy link
Member

Description

The "Don't allow sites to connect to HID devices" option does not have an icon in 1.59.x, it does in 1.58.x.

Steps to Reproduce

  1. Navigate to brave://settings/content/hidDevices

Actual result:

1 59

Expected result:

Setting should have an icon as it does in 1.58.x, although likely a different one than below.

1 58

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.59.109 Chromium: 118.0.5993.21 (Official Build) beta (x86_64)
-- | --
Revision | aacb6a6f8bd916bd49f064b2137b007fa6c47b51
OS | macOS Version 13.6 (Build 22G120)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.58.x no
  • Can you reproduce this issue with the beta channel? 1.59.x yes
  • Can you reproduce this issue with the nightly channel? 1.60.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron

@rebron
Copy link
Collaborator

rebron commented Oct 3, 2023

cc: @aguscruiz

@aguscruiz
Copy link

@fallaciousreasoning we have this as sparkles-off in Nala

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 3, 2023
@MadhaviSeelam
Copy link

Reproduced the issue in Linux & Windows 11.

@kjozwiak
Copy link
Member

The above requires 1.59.116 or higher for 1.59.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 11, 2023

Verification PASSED using

Brave | 1.59.116 Chromium: 118.0.5993.54 (Official Build) (64-bit)
-- | --
Revision | 90abf7b54063101d6494b361dcadeea7c9a4b366
OS | Windows 11 Version 22H2 (Build 22621.2283)

Verified using original STR from #33380 (comment)

image

@fallaciousreasoning
Copy link

Thanks for looking at this so quickly @MadhaviSeelam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants