Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line to disable the PDFJS extension #335

Closed
bbondy opened this issue Jun 13, 2018 · 3 comments
Closed

Add command line to disable the PDFJS extension #335

bbondy opened this issue Jun 13, 2018 · 3 comments
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jun 13, 2018

--disable_pdfjs_extension
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 13, 2018
@bbondy bbondy self-assigned this Jun 13, 2018
bbondy added a commit that referenced this issue Jun 13, 2018
@bbondy
Add --disable_pdfjs_extension switch
5a520da 
Fix #335
bbondy added a commit to brave/brave-core that referenced this issue Jun 13, 2018
@bbondy
Add --disable_pdfjs-extension switch
27c4622 
Fix brave/brave-browser#335
This was referenced Jun 13, 2018
Merged
Merged
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018

QA notes:
You need a fresh profile to test this one.
You can verify if installed in about:extensions

@srirambv srirambv mentioned this issue Aug 21, 2018
Closed
@srirambv srirambv mentioned this issue Sep 24, 2018
Closed
@srirambv
Copy link
Contributor

Blocked on #1253

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 16, 2018 •
edited by btlechowski
Loading

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • PDFJS appears as component under brave://components

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • PDFJS appears as component under brave://components

Verification passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@bbondy
Add --disable_pdfjs_extension switch
0ca36a5 
Fix brave/brave-browser#335
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@bbondy
Add --disable_pdfjs_extension switch
e68beca 
Fix brave/brave-browser#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @srirambv @LaurenWags @btlechowski