Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting for Leo responses #33668

Closed
petemill opened this issue Oct 16, 2023 · 6 comments · Fixed by brave/brave-core#21342
Closed

Code formatting for Leo responses #33668

petemill opened this issue Oct 16, 2023 · 6 comments · Fixed by brave/brave-core#21342

Comments

@petemill
Copy link
Member

petemill commented Oct 16, 2023

Identify which parts of Leo's response is code, and format appropriately.

image

Figma: https://www.figma.com/file/MNwi0uwXNhkAbPiJ86G4vm/%F0%9F%A7%A0-Leo?type=design&node-id=1592-7938&mode=design&t=mmPIf91aKWeWk2PA-0

@petemill petemill converted this from a draft issue Oct 16, 2023
@petemill
Copy link
Member Author

@LorenzoMinto do you have any preferences?

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Oct 24, 2023

From quickly skimming the paper, Codellama seems to have been trained both with ```, ```{language} or even [{language}]...[/{language}] tags (i.e. [PYTHON]...[\PYTHON], similar to the instruction ones). I guess we could use the traditional ``` (or ```{language}) also to be consistent with what we are going to expect from other models

@thypon
Copy link
Member

thypon commented Nov 14, 2023

Are we planning/using markdown anywhere there?

@nullhook nullhook self-assigned this Nov 29, 2023
@nullhook nullhook moved this from Important / Polish to In Progress in Browser AI Nov 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Jan 17, 2024
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 17, 2024
@nullhook nullhook moved this from Done to Needs Uplift in Browser AI Jan 17, 2024
@kjozwiak kjozwiak moved this from Needs Uplift to Done - 1.60.x in Browser AI Jan 20, 2024
@kjozwiak kjozwiak moved this from Done - 1.60.x to Done in Browser AI Jan 20, 2024
@kjozwiak kjozwiak modified the milestones: 1.63.x - Beta, 1.61.x - Release #9, 1.62.x - Release Jan 20, 2024
@kjozwiak
Copy link
Member

Adding QA/Blocked for now as the above was merged into cr121-1.62.x via brave/brave-core#21593. Once C121 is merged into 1.62.x via brave/brave-core#21593, we'll unblock the above and mention the needed 1.62.x version for verification 👍

@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@stephendonner
Copy link

stephendonner commented Jan 22, 2024

Verification PASSED using

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.62.149
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. subscribed to Premium using jan22@mailinator.com from account.bravesoftware.com
  4. clicked on Leo
  5. typed test
  6. clicked on Accept and begin
  7. confirmed default choice of Mixtral LLM
  8. asked Leo to write "Hello, world" programs in different languages

Confirmed Leo (Mixtral) correctly formatted the test programs, as well as the Copy code button

C++ - PASSED

Screen Shot 2024-01-22 at 12 15 46 PM

Code sample:

#include <iostream>

int main() {
    std::cout << "Hello, world!" << std::endl;
    return 0;
}

JavaScript - PASSED

Screen Shot 2024-01-22 at 12 17 28 PM

Python - PASSED

Screen Shot 2024-01-22 at 12 18 15 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants