Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Facebook action and comment IDs from URLs #33984

Closed
fmarier opened this issue Oct 27, 2023 · 3 comments
Closed

Filter Facebook action and comment IDs from URLs #33984

fmarier opened this issue Oct 27, 2023 · 3 comments
Assignees
Labels

Comments

@fmarier
Copy link
Member

fmarier commented Oct 27, 2023

Facebook uses a number of query parameters on links to third-party pages. They all start with fb_.

fb_comment_id presumably helps to leak more information about the referring page than the referrer header:

fb_ref is not clear since it's often single words. It looks more like a campaign parameter.

fb_action_ids is using very long IDs, enough to identify individuals.

fb_source and fb_action_types appear to always be single words from a small list of locations/actions on Facebook.

Example URLs:

@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Oct 27, 2023
@fmarier fmarier self-assigned this Oct 27, 2023
@fmarier
Copy link
Member Author

fmarier commented Oct 27, 2023

All of these will be removed by the "copy clean link" feature: brave/adblock-lists#1379

@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.29 Chromium: 119.0.6045.105 (Official Build) nightly (x86_64)
-- | --
Revision | 722db0323f23c1aaee8a62326083bced61909279
OS | macOS Version 14.2 (Build 23C5030f)

Steps:

  1. installed 1.62.29
  2. launched Brave
  3. loaded https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes with the Developer Tools' console open

Confirmed entering and trying to load https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes resulted in only https://brave.com/?foo=bar&clean=yes being loaded

Screenshot 2023-11-06 at 3 22 59 PM

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

Steps:

  1. installed 1.62.x
  2. launched Brave
  3. loaded https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes with the Developer Tools' console open

Confirmed entering and trying to load https://brave.com/?foo=bar&irclickid=1234&ymclid=abcd&ysclid=efgh&fb_action_ids=5678&fb_comment_id=123456&clean=yes resulted in only https://brave.com/?foo=bar&clean=yes being loaded

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

3 participants