Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Bookmarks & Reading list buttons on the sidebar in Guest window #34162

Closed
MadhaviSeelam opened this issue Nov 7, 2023 · 1 comment · Fixed by brave/brave-core#20934

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 7, 2023

Description

Found while testing #31644

Steps to Reproduce

  1. Install 1.62.32
  2. launch Brave
  3. click Hamburger >> More tools >> Open Guest profile
  4. click on Bookmarks button on the sidebar

Actual result:

image

Expected result:

Disable to Bookmarks & Reading list buttons on the sidebar in the Guest window```

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.62.32 Chromium: 119.0.6045.105 (Official Build) nightly (64-bit)
-- | --
Revision | 76f975d47c49751a29f222762c1a24bd7df88cef
OS | Windows 11 Version 22H2 (Build 22621.2428)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @aguscruiz

@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.38 Chromium: 119.0.6045.134 (Official Build) nightly (x86_64)
-- | --
Revision | 63d368dd4d01900c1f3f056b6371210d10899d5a
OS | macOS Version 14.2 (Build 23C5041e)

First, reproduced using 1.61.32:

example example
Screenshot 2023-11-10 at 4 04 42 PM Screenshot 2023-11-10 at 4 43 00 PM

Then, confirmed that Bookmarks and Reading List buttons are disabled when in a Guest window/profile

example example
Screenshot 2023-11-10 at 3 29 13 PM Screenshot 2023-11-10 at 3 29 37 PM

@rebron rebron changed the title Disable to Bookmarks & Reading list buttons on the sidebar in the Guest window Disable Bookmarks & Reading list buttons on the sidebar in the Guest window Nov 14, 2023
@rebron rebron changed the title Disable Bookmarks & Reading list buttons on the sidebar in the Guest window Disable Bookmarks & Reading list buttons on the sidebar in Guest window Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants