Sidebar icons overlay full screen for some users

[Brave-Matt]

Description

For some users, the icons on the sidebar do not disappear when either the browser itself or a video play is set to full screen. The issue occurs only when the sidebar is set to always show. Disabling/re-enabling the side bar does not resolve the issue and issue occurs on macOS and Windows systems.

See sidebar icons on the left bleeding through.

One user reports:

Happens when a webpage or opened html file uses document.body.requestFullscreen(); function to enter fullscreen.

Steps to Reproduce

1. Have sidebar set to show "always"
2. Put Brave in Full screen mode (optional)
3. Visit a website with full screen video player
4. Set player to full screen

Reproduces how often:

Easily/always for those who can reproduce it

Brave version (brave://version info)

Reported versions:
v1.63.131
v1.62.153

Version/Channel Information:

• Can you reproduce this issue with the current release? Y
• Can you reproduce this issue with the beta channel? Y
• Can you reproduce this issue with the nightly channel? N

Miscellaneous Information:

User report:
https://community.brave.com/t/sidebar-icons-stuck-in-full-screen-player/527867

[Brave-Matt]

Good number of users still reporting this issue after updating to latest.

cc @rebron

[rebron]

cc: @simonhong @sangwoo108

[simonhong]

checking

[MadhaviSeelam]

Adding QA/Test-All-Platforms label as the issue was reported on macOS & Win.

[MadhaviSeelam]

Verification PASSED using

Brave | 1.65.83 Chromium: 123.0.6312.46 (Official Build) beta (64-bit)
-- | --
Revision | 1ea667c8c59a4a4a327579974ec11149a738e750
OS | Windows 11 Version 23H2 (Build 22631.3296)

Reproduced the issue in 1.64.105 Chromium: 123.0.6312.46 in Win 11 x64

1. Installed 1.65.83
2. launched Brave
3. opened brave://settings/appearance
4. select Show on the left for Sidebar option
5. opened a new tab loaded youtube.com
6. played a clip https://www.youtube.com/watch?v=RDoy5X38iio
7. entered video to full screen

Confirmed sidebar UI/icons are not shown

step 4	step 6	step 7

[stephendonner]

Verified PASSED using

Brave	1.65.87 Chromium: 123.0.6312.46 (Official Build) beta (x86_64) 
Revision	2babfcf82ebba4c5dc0146d2ca66229ffd3ac02d
OS	macOS Version 11.7.10 (Build 20G1427)

First, reproduced the issue using 1.64.105:

Steps:

1. installed 1.65.87
2. launched Brave
3. set Show sidebar to Always in brave://settings/appearance
4. set Show on the left
5. played https://www.youtube.com/watch?v=56WBs0A4Kng
6. entered full-screen mode

Confirmed no sidebar elements appear

example	example

[MadhaviSeelam]

Verification PASSED using

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	Linux

Reproduced the issue in 1.64.104 Chromium: 123.0.6312.46

• installed 1.65.87
• launched Brave
• set Show sidebar to Always in brave://settings/appearance
• set Show on the left
• played https://www.youtube.com/watch?v=56WBs0A4Kng
• entered full-screen mode

Confirmed sidebar UI/icons are not shown

example	example	example