Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close, Minimize & Maximize buttons should be larger/fill full vertical space in Windows #35918

Closed
ghost opened this issue Feb 9, 2024 · 2 comments · Fixed by brave/brave-core#22025
Closed

Close, Minimize & Maximize buttons should be larger/fill full vertical space in Windows #35918

ghost opened this issue Feb 9, 2024 · 2 comments · Fixed by brave/brave-core#22025
Assignees
@zenparsing
Labels
feature/tabs-bar OS/Desktop OS/Windows polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@ghost
Copy link

ghost commented Feb 9, 2024

Close, Minimize and Maximize buttons which are at the top right corner are not at the centre, unlike Chrome and Firefox.

Here you can see it-

Brave:
brave
Chrome:
chrome
Firefox:
firefox

Brave version: 1.62.162
Windows 11 22H2
@ghost ghost added the OS/Desktop label Feb 9, 2024
@rebron
Copy link
Collaborator

rebron commented Feb 9, 2024

cc: @zenparsing @simonhong

@rebron rebron added polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Feb 9, 2024
@rebron rebron changed the title Close, Minimize & Maximize buttons are not at the centre in Windows Close, Minimize & Maximize buttons should be larger/fill full vertical space in Windows Feb 9, 2024
@zenparsing zenparsing assigned zenparsing and unassigned zenparsing Feb 10, 2024
@zenparsing zenparsing self-assigned this Feb 20, 2024
@zenparsing zenparsing mentioned this issue Feb 20, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 21, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.65.87 Chromium: 123.0.6312.46 (Official Build) beta (64-bit)
-- | --
Revision | 2babfcf82ebba4c5dc0146d2ca66229ffd3ac02d
OS | Windows 11 Version 23H2 (Build 22631.3296)
Close Minimize Maximize
image image image

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
@xzuke xzuke mentioned this issue Jun 27, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/tabs-bar OS/Desktop OS/Windows polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Replace patches in BrowserFrameViewWin with overrides brave/brave-core
4 participants
@rebron @zenparsing @brave-builds @MadhaviSeelam