Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace patches in BrowserFrameViewWin with overrides #22025

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 13, 2024

Resolves brave/brave-browser#35980
Resolves brave/brave-browser#35918

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from mkarolin February 13, 2024 18:19
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-browserview-win-overrides branch 2 times, most recently from 784b9d7 to 940193b Compare February 20, 2024 15:21
@zenparsing zenparsing force-pushed the ksmith-browserview-win-overrides branch from 940193b to b3617bb Compare February 20, 2024 18:08
@zenparsing zenparsing requested a review from mkarolin February 20, 2024 19:14
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 50fc21a into master Feb 21, 2024
19 checks passed
@zenparsing zenparsing deleted the ksmith-browserview-win-overrides branch February 21, 2024 15:13
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants