Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Send from NFT details view doesn't enable review button #36605

Closed
srirambv opened this issue Mar 7, 2024 · 2 comments · Fixed by brave/brave-core#22500
Closed

Selecting Send from NFT details view doesn't enable review button #36605

srirambv opened this issue Mar 7, 2024 · 2 comments · Fixed by brave/brave-core#22500
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2024

Description

Selecting Send from NFT details view doesn't enable review button

Steps to Reproduce

  1. Restore wallet with NFT
  2. Open NFT tab and select Yes to auto discovery
  3. Once NFT is discovered open NFT details view
  4. Select Send from the NFT details view and select the recevier account address
  5. Review send button doesn't get enabled
  6. Click on select asset again and select the same NFT
  7. Add/Select the receiving address
  8. Review Send button is enabled and able to submit a NFT send transaction

Actual result:

Send.NFT.mp4

Expected result:

Should be able to review and send from NFT details view

Reproduces how often:

Easy

Desktop Brave version:

All

Android Device details:

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @muliswilliam
@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 7, 2024
@srirambv srirambv added this to Web3 Mar 7, 2024
@Douglashdaniel Douglashdaniel self-assigned this Mar 7, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 7, 2024
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 7, 2024
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 7, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 7, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 7, 2024
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from issue description
  • Verified selecting receiving address on Send NFT screen enables the Review send button
22500.mp4

@srirambv
Copy link
Contributor Author

Verification passed on Google Pixel 8 with Android 14 running 1.65.89 x64 Beta build

  • Verified steps from issue description
  • Verified selecting receiving address on Send NFT screen enables the Review send button
36605.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants