Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewed, dismissed, clicked and landed Confirmations controlled by estimated redemption value #3690

Closed
tmancey opened this issue Mar 12, 2019 · 2 comments · Fixed by brave/brave-core#1920

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 12, 2019

We have view, dismiss, click and landed confirmation types but only views are shown in the UI under "Current earnings this month (Estimated)" and "Ad notifications received".

Would it make more sense to show "Current earnings this month (Estimated)" and "Ad notifications received" for any confirmation type with an estimated redemption value greater than 0.0BAT.

This would mean we can decide which confirmation types can be redeemed and if the estimated redemption value is set to 0.0BAT then the confirmation can just be used for stats.

Test Plan:

Confirm that any issuers with a value greater than 0.0BAT are counted in the UI

@tmancey tmancey changed the title Viewed, dismissed, clicked and landed Confirmations redemption should be controlled by issuer value Viewed, dismissed, clicked and landed Confirmations controlled by estimated redemption value Mar 12, 2019
@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 12, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 12, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 13, 2019
@tmancey tmancey added the QA/Yes label Mar 13, 2019
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 13, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 13, 2019
@bsclifton
Copy link
Member

Updated milestone after brave/brave-core#1926 was merged

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 5, 2019

Verification passed on both

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
Brave 0.64.37 Chromium: 74.0.3729.40 (Official Build) dev (64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Windows 10 OS Build 17134.523

Dev Build:
image (1)

Beta Build:

landed confirmation type is not recorded as viewed ads redirected to another link, hence confirmation type is NOT recorded.
image (2)

landed confirmation type is recorded as viewed ads did not redirected to other links, hence confirmation type is recorded.
image

Verification passed on both

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
Brave 0.64.37 Chromium: 74.0.3729.40 (Official Build) dev(64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Linux

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Screen Shot 2019-04-17 at 12 39 57 PM

![Screen Shot 2019-04-17 at 12 40 50 PM](https://user-images.githubusercontent.com/28145373/56305429-47969c80-610e-11e9-8cee-cc3a54a90728.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment