-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewed, dismissed, clicked and landed Confirmations controlled by estimated redemption value #3690
Labels
feature/ads
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
tmancey
changed the title
Viewed, dismissed, clicked and landed Confirmations redemption should be controlled by issuer value
Viewed, dismissed, clicked and landed Confirmations controlled by estimated redemption value
Mar 12, 2019
19 tasks
jsecretan
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Mar 12, 2019
tmancey
added a commit
to brave/brave-core
that referenced
this issue
Mar 12, 2019
…imated redemption value fixes brave/brave-browser#3690
tmancey
added a commit
to brave/brave-core
that referenced
this issue
Mar 13, 2019
…imated redemption value fixes brave/brave-browser#3690
tmancey
added a commit
to brave/brave-core
that referenced
this issue
Mar 13, 2019
…imated redemption value fixes brave/brave-browser#3690
Updated milestone after brave/brave-core#1926 was merged |
Verification passed on both
Beta Build:
Verification passed on both
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ads
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
We have view, dismiss, click and landed confirmation types but only views are shown in the UI under "Current earnings this month (Estimated)" and "Ad notifications received".
Would it make more sense to show "Current earnings this month (Estimated)" and "Ad notifications received" for any confirmation type with an estimated redemption value greater than 0.0BAT.
This would mean we can decide which confirmation types can be redeemed and if the estimated redemption value is set to 0.0BAT then the confirmation can just be used for stats.
Test Plan:
Confirm that any issuers with a value greater than 0.0BAT are counted in the UI
The text was updated successfully, but these errors were encountered: