Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable button in the download manager #38905

Closed
1 of 6 tasks
fmarier opened this issue Jun 8, 2024 · 2 comments · Fixed by brave/brave-core#24320
Closed
1 of 6 tasks

Unreadable button in the download manager #38905

fmarier opened this issue Jun 8, 2024 · 2 comments · Fixed by brave/brave-core#24320

Comments

@fmarier
Copy link
Member

fmarier commented Jun 8, 2024

Description

Due to a bad color choice, the button to trash the download is unreadable.

Steps to reproduce

  1. Open https://testsafebrowsing.appspot.com/
  2. Download Should show an "uncommon" warning, for .exe under Download desktop warning
  3. Click the download button in the URL bar
  4. Click the file that was just downloaded but blocked by Safe Browsing.

Actual result

Screenshot from 2024-06-08 12-04-00

Expected result

Should be white on dark blue instead of black on dark blue.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.67.108 Chromium: 126.0.6478.40 (Official Build) beta (64-bit) 
Revision	a286dc9f61f7d70fbf0157fcf3d924b00297d450
OS	Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.67.123 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 10 Version 22H2 (Build 19045.4529)

Using the STR/Cases outlined via #38905 (comment), ensured that the correct UI/colouring was being used via the uncommon" .exe warning as per the following:

Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment