Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add View on Block Explorer button to Account Details menu #39655

Closed
Douglashdaniel opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24607
Closed

Add View on Block Explorer button to Account Details menu #39655

Douglashdaniel opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24607
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

Linux, macOS, Windows

Description

We should add a View on block explorer button to the Account Details menu, which would pop a Network selector for EVM accounts.

Screenshot 12
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 9, 2024
@Douglashdaniel Douglashdaniel self-assigned this Jul 9, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jul 9, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jul 11, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jul 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 12, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 12, 2024
@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2024

Verification passed on

Brave 1.69.136 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
Revision 47255350e0d135b2172cb9dd2ba344d3d7fe4572
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24607
  • Verified Block explorer option is shown in account menu
  • Verified for Ethereum account shows all EVM networks when view on block explorer option is selected
  • Verified for Bitcoin and ZCash there is no view on block explorer option
39655.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): View on Block Explorer Modal brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds