Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): View on Block Explorer Modal #24607

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

  • Introduces a View on block explorer button on the Account Details page
  • Introduces a View on block explorer modal for EVM and SVM networks, to allow user to select which Block Explorer to view their account on.

Resolves brave/brave-browser#39655

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Accounts page.
  2. Click on an Ethereum account and then click on the View on block explorer button
  3. You should see the View on block explorer modal
  4. Test clicking on networks to view on it's Block Explorer.
  5. Follow these same steps for a Solana account
  6. Now test clicking on the View on block explorer button for a Filecion and Filecoin Testnet account
  7. It should open directly to the Block Explorer
  8. BTC and ZEC accounts are currently not supported for this feature, so there should not be a View on block explorer button.
Screen.Recording.11.mov

@Douglashdaniel Douglashdaniel self-assigned this Jul 11, 2024
@Douglashdaniel Douglashdaniel requested review from a team as code owners July 11, 2024 15:40
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jul 11, 2024
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-view-on-block-explorer-modal branch from 074f9e0 to 240cb8d Compare July 11, 2024 16:04
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@Douglashdaniel Douglashdaniel merged commit 7785f3c into master Jul 12, 2024
16 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-view-on-block-explorer-modal branch July 12, 2024 14:37
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add View on Block Explorer button to Account Details menu
5 participants