Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified sites need a different BAT logo #4043

Closed
mandar-brave opened this issue Apr 8, 2019 · 11 comments · Fixed by brave/brave-core#2294
Closed

Verified sites need a different BAT logo #4043

mandar-brave opened this issue Apr 8, 2019 · 11 comments · Fixed by brave/brave-core#2294

Comments

@mandar-brave
Copy link

Verified BAT sites should show a different logo (original logo had a blue bar for verified sites) so user knows pre-logo click that site was verified.

cc @NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 8, 2019
@mandar-brave
Copy link
Author

@jenn-rhim can we pull the original design for this!

@mandar-brave
Copy link
Author

@rossmoody we need an icon for the change.
cc @ryanml

@NejcZdovc
Copy link
Contributor

waiting for design and final decision on how it will work

@rossmoody
Copy link
Contributor

@davidtemkin Has some final fine tuning to do and then we should be good to go, I think.

@rossmoody
Copy link
Contributor

Rewards Verified Toolbar

@davidtemkin
Copy link

@rossmoody @ryanml still some discussion needed -- we are not yet final-final -- please hold implementation for a moment

@davidtemkin
Copy link

@rossmoody @ryanml -- OK, confirmed all with @bradleyrichter and we are good to go with the above

@NejcZdovc
Copy link
Contributor

so if I understand image correctly, if you have notification we don't show any indication for verified publisher?

@rossmoody
Copy link
Contributor

Yea, the notification would take priority until it's cleared.

@NejcZdovc
Copy link
Contributor

ok sounds good

@btlechowski
Copy link

btlechowski commented Jun 12, 2019

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

Verified test plan from brave/brave-core#2294
Logged #4817

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Linux

Verification PASSED* on macOS 10.14.5 x64 using the following build:

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants