Brave Ads: display 7-day ads history and feedback options for viewed ads

[mandar-brave]

Specification details -- images and UX coming shortly.

V1.1 User feedback changes

The Brave Ads panels will be expanded to have a Browser history; this browser history table will also be allowing multi-functional actions back from the user.

In V1.0, the actions are;
Don’t send me this again - Block ad from notifying me again
Dismiss action on Ad will perform the same action
Save - Want to ensure Ad is saved for future viewing
Adds to Bookmark
Flag - Ad is very inappropriate
This will also trigger Action#1
Personalize Ads - add/remove categories i am interested in
Includes LDA check upfront
These categories will be flagged the highest in the taxonomy
Categories opted out will be tagged opted out forever

Mock for Ads Rewards feedback panel
Note: Mock is not complete and needs to be re-rendered

User flow
The user can reach the User feedback setting as part of Brave rewards. The user can see which ads were delivered for the last 30 days with the following detail;
Advertiser detail (main + ad-text)
Category why ad was delivered and allow quick click to opt out for that specific category
Viewed or Clicked or Dismissed
Earned reward per line level item

The above details provide a bookmark view of Ads viewed in the past. The user can decide to choose the dismissed Ads to personalize ad viewing. The user can opt out of Ad categories, including 18 and over.

In the same flow, the user can decide to personalize further and decide not opt out of categories. When the user opts out, they are opted out of those categories permanently. The user can search through categories via drop down or by searching for them. Similarly, a user can decide to opt in to certain categories in the same flow.

Spec: https://docs.google.com/document/d/1XusXB1li8I7Q-3PAk3-2BcdujwZ0Y6oD0yNvhsahZgc/edit#heading=h.l7wtf1v849do

@jsecretan V1.1 prioritization
@NejcZdovc user feedback loop in Brave Rewards
@jenn-rhim to prioritize the visualization of the user feedback loop

[mandar-brave]

@jenn-rhim would love to ship the current design for user feedback loop. If you can post it, i can get the details from the spec to map to the UI. cc @alexwykoff

[jsecretan]

Some things to clarify for @emerick is that

1. When the upvote/downvote on the ad is selected, it will send an "upvote" or "downvote" type of confirmation associated with the creativeInstanceId of that ad.
2. The ad delivery logic should then avoid delivering anything with the same creativeSetId (note that this is broader than just creativeInstanceId) as anything that was downvoted.
3. When and ad is downvoted, it is probably wise to store creativeInstanceId, creativeId, creativeSetId, campaignId and advertiserId just in case the blocking rules change in the future

[jsecretan]

And after discussion with @tmancey and @emerick, we should also filter out creativesets that are associated with downvoted categories.

[jsecretan]

Flag as inappropriate should send "flag" confirmation type. And when flagged, should follow the same creativesetid blocking as downvote.

[LaurenWags]

Verified passed with

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Support Ads history and feedback loop brave-core#2792
• Verified Ads older than 7days were not displayed in the main view of Ads History panel
• Verified Viewed, Clicked, Dismissed ads display in Ads History
• Verified All/Saved/Thumbs up views filtered when clicked on
• Verified filtered_ads, filtered_categories, saved_ads, and flagged_ads were populated in client.json as described by the PR
• Logged follow up issues: Brave Ads history popup tooltip text needed #6204, Ads History popup shows 2 entries for the same ad (even if only served once) #6205, Brave Ads history popup data appears to clear out in certain cases, reopen fixes it #6206, brave://rewards needs to be refreshed to show 7-day Brave Ads history link #6207, Saved ads on Brave Ads history popup is not intuitive #6208, Brave Ads history link only shows on upgrade after an ad is served, previous history not displayed #6209

Verification passed on

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Support Ads history and feedback loop brave-core#2792
• Verified Ads older than 7days were not displayed in the main view of Ads History panel
• Verified Viewed, Clicked, Dismissed ads display in Ads History
• Verified All/Saved/Thumbs up views filtered when clicked on
• Verified filtered_ads, filtered_categories, saved_ads, and flagged_ads were populated in client.json as described by the PR
• Encountered issues: Brave Ads history popup tooltip text needed #6204, Ads History popup shows 2 entries for the same ad (even if only served once) #6205, Brave Ads history popup data appears to clear out in certain cases, reopen fixes it #6206, brave://rewards needs to be refreshed to show 7-day Brave Ads history link #6207, Saved ads on Brave Ads history popup is not intuitive #6208, Brave Ads history link only shows on upgrade after an ad is served, previous history not displayed #6209

Verification passed on

Brave	0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

• Verified test plan from Support Ads history and feedback loop brave-core#2792
• Verified Ads older than 7days were not displayed in the main view of Ads History panel
• Verified Viewed, Clicked, Dismissed ads display in Ads History
• Verified All/Saved/Thumbs up views filtered when clicked on
• Verified filtered_ads, filtered_categories, saved_ads, and flagged_ads were populated in client.json as described by the PR
• Encountered issues: Brave Ads history popup tooltip text needed #6204, Ads History popup shows 2 entries for the same ad (even if only served once) #6205, Brave Ads history popup data appears to clear out in certain cases, reopen fixes it #6206, brave://rewards needs to be refreshed to show 7-day Brave Ads history link #6207, Saved ads on Brave Ads history popup is not intuitive #6208, Brave Ads history link only shows on upgrade after an ad is served, previous history not displayed #6209

[tmancey]

@jsecretan @emerick Adding the following comment, which we previously discussed to help QA with #7833

Ads viewed count will be reset to zero due to legacy ads history having to be cleared out as we only stored a timestamp