Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Update relative times in the feed #40875

Closed
fallaciousreasoning opened this issue Sep 5, 2024 · 1 comment · Fixed by brave/brave-core#25447
Closed

[Brave News]: Update relative times in the feed #40875

fallaciousreasoning opened this issue Sep 5, 2024 · 1 comment · Fixed by brave/brave-core#25447
Assignees
@fallaciousreasoning
Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.71.x - Release

Comments

@fallaciousreasoning
Copy link

Steps to repro

  1. Open a feed
  2. Observe the relative time on a relatively new article (like 1 hour ago)
  3. Wait an hour

Expected result:
The publish time is 2 hours ago

Actual result
The publish time is 1 hour ago
@fallaciousreasoning fallaciousreasoning self-assigned this Sep 5, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue Sep 5, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 10, 2024
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 10, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.71.111 Chromium: 130.0.6723.31 (Official Build) (64-bit)
-- | --
Revision | a39f12f230248c726d3f1cac2d59dd4dcac714d7
OS | Windows 11 Version 23H2 (Build 22631.4317)

Reproduced the issue in 1.70.126 Chromium: 129.0.6668.100

example example
Image Image
  1. Installed 1.71.111
  2. launched Brave
  3. enable news via Turn on News
  4. observed the relative time on a relatively new article at 2:22 pm
    • first article show 48 minutes ago
    • second article show 6 hours ago
  5. waited for an hour

Confirmed relative times in the feed got updated as below at 3.25 pm

  • first article (CBR) shows 2 hours ago
  • second article (Hollywood Reporter) shows 7 hours ago
example example
Image Image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

[Brave News]: Update relative times displayed in the feed brave/brave-core
3 participants
@fallaciousreasoning @brave-builds @MadhaviSeelam