Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Update relative times displayed in the feed #25447

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[Brave News]: Update relative times displayed in the feed #25447

merged 1 commit into from
Sep 10, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#40875

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 5, 2024
fallaciousreasoning
fallaciousreasoning commented Sep 5, 2024
View reviewed changes
components/brave_news/browser/resources/shared/Icons.tsx Outdated
@@ -14,7 +14,7 @@ export const ArrowRight = <svg width="16" height="15" viewBox="0 0 16 15" fill="
<path d="M9.76613 7.85573L4.78172 2.18596C4.49438 1.85911 4.54097 1.37334 4.88577 1.10097C5.23058 0.828593 5.74304 0.872754 6.03038 1.1996L11.4484 7.36255C11.6995 7.64824 11.6995 8.06322 11.4484 8.34891L6.03038 14.5119C5.74304 14.8387 5.23058 14.8829 4.88577 14.6105C4.54097 14.3381 4.49438 13.8523 4.78172 13.5255L9.76613 7.85573Z" fill="currentColor" />
</svg>

export const channelIcons = {
export const channelIcons: {[category: string]: JSX.Element } = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I was getting a compile error without this

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 3863f77 into master Sep 10, 2024
17 checks passed
@fallaciousreasoning fallaciousreasoning deleted the bn-relative-time branch September 10, 2024 09:50
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzoMinto LorenzoMinto LorenzoMinto approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.71.x - Beta
Development

Successfully merging this pull request may close these issues.

[Brave News]: Update relative times in the feed
3 participants
@fallaciousreasoning @brave-builds @LorenzoMinto