Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Update "Indirect Support" text for non-connected users in Rewards 2.5 panel #40909

Closed
Miyayes opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25468 or brave/brave-core#25491
Closed

[iOS] Update "Indirect Support" text for non-connected users in Rewards 2.5 panel #40909

Miyayes opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25468 or brave/brave-core#25491
Assignees
@kylehickinson
Labels
feature/rewards OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.70.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 6, 2024

https://github.com/brave/internal/issues/1186
@Miyayes Miyayes added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/iOS Fixes related to iOS browser functionality labels Sep 6, 2024
@kylehickinson kylehickinson mentioned this issue Sep 6, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 6, 2024
@brave-builds brave-builds mentioned this issue Sep 6, 2024
Merged
7 tasks
@kylehickinson kylehickinson mentioned this issue Sep 9, 2024
Merged
24 tasks
@kjozwiak
Copy link
Member

The above requires 1.70.108 or higher for 1.70.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 17, 2024
@hffvld
Copy link
Contributor

hffvld commented Sep 17, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.70 (114)
BraveCore: 1.70.114 (129.0.6668.42)

ACTUAL RESULTS:

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 17, 2024
@kjozwiak kjozwiak mentioned this issue Sep 25, 2024
Closed
19 tasks
@Uni-verse Uni-verse mentioned this issue Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
feature/rewards OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - iPhone QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Updates Rewards panel copy brave/brave-core
[iOS] Fix Rewards panel copy brave/brave-core
5 participants
@kylehickinson @kjozwiak @Miyayes @brave-builds @hffvld