Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Updates Rewards panel copy (uplift to 1.70.x) #25479

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[iOS] Updates Rewards panel copy (uplift to 1.70.x) #25479

merged 1 commit into from
Sep 10, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 6, 2024 •
edited by kjozwiak
Loading

Uplift of #25468
Uplift of #25491
Resolves brave/brave-browser#40909

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 6, 2024 19:50
@brave-builds brave-builds added this to the 1.70.x - Beta milestone Sep 6, 2024
@brave-builds brave-builds self-assigned this Sep 6, 2024
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 6, 2024
@kylehickinson kylehickinson force-pushed the pr25468_ios-rewards-copy-change_1.70.x branch from f246aa4 to d9f392b Compare September 9, 2024 13:42
kjozwiak
kjozwiak approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍 QA has verified the PR on Nightly using 1.71.x as per #25468 (comment).

@kjozwiak kjozwiak merged commit 01eecf1 into 1.70.x Sep 10, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr25468_ios-rewards-copy-change_1.70.x branch September 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @kylehickinson