Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Google Lens from View menu on macOS #41117

Closed
2 of 6 tasks
rebron opened this issue Sep 18, 2024 · 4 comments · Fixed by brave/brave-core#25625
Closed
2 of 6 tasks

Remove Google Lens from View menu on macOS #41117

rebron opened this issue Sep 18, 2024 · 4 comments · Fixed by brave/brave-core#25625
Assignees
@mkarolin
Labels
branding google OS/Desktop OS/macOS OS/macOS-arm64 polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release/blocking release-notes/exclude
Milestone
1.70.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 18, 2024

Description

In latest beta, 1.71.88 Chromium: 129.0.6668.42, there's an Always show Google Lens shortcut menu item on macOS.
That menu item should be removed.

Steps to reproduce

  1. Install 1.71.88 Chromium: 129.0.6668.42 or higher on macOS
  2. Open View menu.
  3. Notice Google Lens menu item

Actual result

Screenshot 2024-09-17 at 8 14 14 PM

Expected result

No menu item for Google Lens.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.71.88 Chromium: 129.0.6668.42

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added OS/Desktop polish Nice to have — usually related to front-end/visual tasks google branding labels Sep 18, 2024
@rebron rebron added this to the 1.70.x - Release milestone Sep 18, 2024
@rebron rebron added release/blocking priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes labels Sep 18, 2024
@mkarolin mkarolin mentioned this issue Sep 18, 2024
Merged
24 tasks
This was referenced Sep 18, 2024
Merged
Merged
@LaurenWags
Copy link
Member

Adding QA/Blocked label until this is uplifted.

@rebron rebron removed this from the 1.70.x - Release milestone Sep 18, 2024
@kjozwiak kjozwiak added this to the 1.70.x - Release milestone Sep 18, 2024
@kjozwiak
Copy link
Member

The above requires 1.70.117 or higher for 1.70.x verification 👍

@LaurenWags LaurenWags added OS/macOS-arm64 QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 19, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Sep 19, 2024 •
edited
Loading

Verified with

Brave | 1.70.117 Chromium: 129.0.6668.59 (Official Build) (x86_64)
-- | --
Revision | 5d4da8332eb061f79bb47ec5b0bf595600fdcd55
OS | macOS Version 14.6.1 (Build 23G93)

Reproduced the issue using 1.70.115.
Using 1.70.117 confirmed the menu item is no longer displayed.

1.70.115 1.70.117
115 117

@LaurenWags
Copy link
Member

Verified with

Brave	1.70.117 Chromium: 129.0.6668.59 (Official Build) (arm64) 
Revision	5d4da8332eb061f79bb47ec5b0bf595600fdcd55
OS	macOS Version 15.0 (Build 24A335)

Reproduced the issue using 1.70.115.
Using 1.70.117 confirmed the menu item is no longer displayed.

1.70.115 1.70.117
115 117

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
branding google OS/Desktop OS/macOS OS/macOS-arm64 polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

[MacOS] Remove Google Lense menu item in View menu. brave/brave-core
5 participants
@kjozwiak @rebron @LaurenWags @GeetaSarvadnya @mkarolin