Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Remove Google Lense menu item in View menu. #25625

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#41117

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Sep 18, 2024
@mkarolin mkarolin requested a review from a team as a code owner September 18, 2024 05:02
@mkarolin mkarolin merged commit 789f668 into master Sep 18, 2024
17 checks passed
@mkarolin mkarolin deleted the maxk-remove-show-lens-menu-macos branch September 18, 2024 13:10
@mkarolin mkarolin added this to the 1.72.x - Nightly milestone Sep 18, 2024
brave-builds added a commit that referenced this pull request Sep 18, 2024
brave-builds added a commit that referenced this pull request Sep 18, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 18, 2024

Verification PASSED using

Brave | 1.72.20 Chromium: 129.0.6668.59 (Official Build) nightly (arm64)
-- | --
Revision | a6a3214a8c112ec9a83bd0974d8ba789c7840631
OS | macOS Version 14.6.1 (Build 23G93)
  • Installed 1.72.20
  • clicked View menu from menu bar

Confirmed Always Show Google Lens Shortcut entry is no longer shown

1.71.88 Chromium: 129.0.6668.42 1.72.20 Chromium: 129.0.6668.59
Screenshot at Sep 18 15-54-05 Screenshot at Sep 18 15-54-40

kjozwiak pushed a commit that referenced this pull request Sep 19, 2024
kjozwiak pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Google Lens from View menu on macOS
3 participants