Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update search engine default for Australia (AU) #41456

Closed
timchilds opened this issue Oct 7, 2024 · 3 comments · Fixed by brave/brave-core#25870
Closed

[Android] Update search engine default for Australia (AU) #41456

timchilds opened this issue Oct 7, 2024 · 3 comments · Fixed by brave/brave-core#25870
Labels
Brave Search OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.71.x - Release #2

Comments

@timchilds
Copy link

timchilds commented Oct 7, 2024 •
edited
Loading

Description

Update search engine default for Australia:

Australia (AU)
Brave should be at the top of the drop down list at settings -> search engines -> standard tab and private tab

Related: #41451

Steps to reproduce

Region set to AU

  1. Fresh profile
  2. Default search engine SHOULD be Brave
  3. Visit settings -> search engines -> standard tab and private tab
  4. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX / BR / AR / IN, IT)

  1. Fresh profile
  2. Default will NOT be Brave Search
  3. Visit settings -> search engines -> standard tab and private tab
  4. Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Notes for test plan
#23814 (comment)

Actual result

see description

Expected result

see description

cc @rebron
@timchilds timchilds added OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include Brave Search labels Oct 7, 2024
@simonhong simonhong mentioned this issue Oct 8, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Oct 9, 2024
@simonhong simonhong mentioned this issue Oct 9, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.71.116 or higher for 1.71.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Oct 23, 2024 •
edited
Loading

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.71.118 Chromium: 130.0.6723.70 (Official Build) (64-bit)
--- | ---
Revision | d29310b051bde8ba041cd7b4edcb41ce951be12c
OS | Android 15; Build/AP41.240823.009; 35; REL

Australia (AU) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Image Image Image
Updated Profile (Google/Google)
  • installed 1.70.126 Chromium 129.0.6668.100
  • ensured that Google was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Google was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70 and ensured that Google is still the default for Standard & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image
Updated Profile (Bing/Startpage)
  • installed 1.70.126 Chromium 129.0.6668.100
  • changed the default SE to Bing under Settings -> Search engines for Standard Tab
  • changed the default SE to Startpage under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70
  • ensured that Bing wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that Startpage wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image

MX (Mexico) locale - PASSED

Clean Profile
  • ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Image Image Image
Updated Profile (Brave/Brave)
  • installed 1.70.126 Chromium 129.0.6668.100
  • ensured that Brave was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Brave was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70
  • ensured that Brave is still the default SE for both Standard Tab & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image
Updated Profile (Qwant/Bing)
  • installed 1.70.126 Chromium 129.0.6668.100
  • changed the default SE to Qwant under Settings -> Search engines for Standard Tab
  • changed the default SE to Bing under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70
  • ensured that Qwant wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that Bing wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image

RU (Russia) locale - PASSED

Clean Profile
  • ensured that Yandex was selected as the default for both Normal/Private windows via Settings -> Search engines
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
Example Example Example
Image Image Image
Updated Profile (Yandex/Yandex)
  • installed 1.70.126 Chromium 129.0.6668.100
  • ensured that Yandex was the default SE selected under Settings -> Search engines for Standard Tab
  • ensured that Yandex was the default SE selected under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70
  • ensured that Yandex is still the default SE for both Standard Tab & Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image
Updated Profile (Startpage/DDG)
  • installed 1.70.126 Chromium 129.0.6668.100
  • changed the default SE to Startpage under Settings -> Search engines for Standard Tab
  • changed the default SE to DDG under Settings -> Search engines for Private Tab
  • updated to 1.71.118 Chromium: 130.0.6723.70
  • ensured that Startpage wasn't replaced with Brave as the default SE for Standard Tab
  • ensured that DDG wasn't replaced with Brave as the default SE for Private Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
  • ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab
1.70.126 Chromium 129.0.6668.100 1.71.118 Chromium: 130.0.6723.70
Image Image
Image Image
Image Image

@hffvld
Copy link
Contributor

hffvld commented Oct 23, 2024 •
edited
Loading

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.71.118
Chromium: 130.0.6723.70 (Official Build) (64-bit)

Region set to Australia

Clean Profile

STEPS:

  1. Switch device Language/Region to English/Australia
  2. Fresh install Brave 1.71.118
  3. Verify

ACTUAL RESULTS:

  • Verified that Brave was selected as the default for both Normal and Private tabs via Settings -> Search engines
  • Verified that Brave was the first engine via the drop-down list under Settings -> Search engines for Standard Tab
  • Verified that Brave was the first engine via the drop-down list under Settings -> Search engines for Private Tab
1 2 3 4
1 2 3 4
Updated Profile (Google/Google)
  1. Switch device Language/Region to English/Australia
  2. Fresh install Brave 1.70.123
  3. Launch Brave > Verify that Google is the default SE
  4. Upgrade Brave to 1.71.118 > Launch Brave
  5. Verify that Google is still the default SE after the upgrade

ACTUAL RESULTS:

  • Verified that Google was the default SE selected under Settings -> Search engines for Standard Tab before Brave upgrade
  • Verified that Google was the default SE selected under Settings -> Search engines for Private Tab before Brave upgrade
  • Verified that Google is still the default SE for the Standard & Private Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3 4
1 2 3 4
1 2 3 4
Updated Profile (Qwant/Ecosia)

STEPS:

  1. Switch device Language/Region to English/Australia
  2. Fresh install Brave 1.70.123 > Launch Brave
  3. Change the default SE to Qwant under Settings -> Search engines for Standard Tab
  4. Change the default SE to Ecosia under Settings -> Search engines for Private Tab
  5. Upgrade Brave to 1.71.118 > Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that Qwant wasn't replaced with Brave as the default SE for Standard Tab after Brave upgrade
  • Verified that Ecosia wasn't replaced with Brave as the default SE for Private Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3
1 2 3
1 2 3

Region set to Argentina

Clean Profile

STEPS:

  1. Switch device Language/Region to Spanish/Argentina
  2. Fresh install Brave 1.71.118
  3. Verify

ACTUAL RESULTS:

  • Verified that Brave was selected as the default for both Normal and Private tabs via Settings -> Search engines
  • Verified that Brave was the first engine via the drop-down list under Settings -> Search engines for Standard Tab
  • Verified that Brave was the first engine via the drop-down list under Settings -> Search engines for Private Tab
1 2 3 4
1 2 3 4
Updated Profile (Brave/Brave)
  1. Switch device Language/Region to Spanish/Argentina
  2. Fresh install Brave 1.70.123
  3. Launch Brave > Verify that Brave is the default SE
  4. Upgrade Brave to 1.71.118 > Launch Brave
  5. Verify that Brave is still the default SE after the upgrade

ACTUAL RESULTS:

  • Verified that Brave was the default SE selected under Settings -> Search engines for Standard Tab before Brave upgrade
  • Verified that Brave was the default SE selected under Settings -> Search engines for Private Tab before Brave upgrade
  • Verified that Brave is still the default SE for the Standard & Private Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3 4
1 2 3 4
1 2 3 4
Updated Profile (DDG/Google)

STEPS:

  1. Switch device Language/Region to Spanish/Argentina
  2. Fresh install Brave 1.70.123 > Launch Brave
  3. Change the default SE to DDG under Settings -> Search engines for Standard Tab
  4. Change the default SE to Google under Settings -> Search engines for Private Tab
  5. Upgrade Brave to 1.71.118 > Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that DDG wasn't replaced with Brave as the default SE for Standard Tab after Brave upgrade
  • Verified that Google wasn't replaced with Brave as the default SE for Private Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3
1 2 3
1 2 3

Region set to Kazakhstan

Clean Profile

STEPS:

  1. Switch device Language/Region to Kaзак тiлi/Kazakhstan
  2. Fresh install Brave 1.71.118
  3. Verify

ACTUAL RESULTS:

  • Verified that Yandex was selected as the default for both Normal and Private tabs via Settings -> Search engines
  • Verified that Brave was the first engine after Yandex via the drop-down list under Settings -> Search engines for Standard Tab
  • Verified that Brave was the first engine after Yandex via the drop-down list under Settings -> Search engines for Private Tab
1 2 3 4
1 2 3 4
Updated Profile (Yandex/Yandex)
  1. Switch device Language/Region to Kaзак тiлi/Kazakhstan
  2. Fresh install Brave 1.70.123
  3. Launch Brave > Verify that Yandex is the default SE
  4. Upgrade Brave to 1.71.118 > Launch Brave
  5. Verify that Yandex is still the default SE after the upgrade

ACTUAL RESULTS:

  • Verified that Yandex was the default SE selected under Settings -> Search engines for Standard Tab before Brave upgrade
  • Verified that Yandex was the default SE selected under Settings -> Search engines for Private Tab before Brave upgrade
  • Verified that Yandex is still the default SE for the Standard & Private Tab after Brave upgrade
  • Verified that Brave was the first SE after Yandex via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE after Yandex via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3 4
1 2 3 4
1 2 3 4
Updated Profile (Bing/Qwant)

STEPS:

  1. Switch device Language/Region to Kaзак тiлi/Kazakhstan
  2. Fresh install Brave 1.70.123 > Launch Brave
  3. Change the default SE to Bing under Settings -> Search engines for Standard Tab
  4. Change the default SE to Qwant under Settings -> Search engines for Private Tab
  5. Upgrade Brave to 1.71.118 > Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that Bing wasn't replaced with Brave as the default SE for Standard Tab after Brave upgrade
  • Verified that Qwant wasn't replaced with Brave as the default SE for Private Tab after Brave upgrade
  • Verified that Brave was the first SE after Yandex via the drop-down list under Settings -> Search engines for the Standard Tab after Brave upgrade
  • Verified that Brave was the first SE after Yandex via the drop-down list under Settings -> Search engines for the Private Tab after Brave upgrade
1 2 3
1 2 3
1 2 3

@hffvld hffvld mentioned this issue Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Brave Search OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.71.x - Release #2
Development

Successfully merging a pull request may close this issue.

Set brave search as a default search provider in AU brave/brave-core
4 participants
@kjozwiak @timchilds @brave-builds @hffvld