Set brave search as a default search provider in AU #25870

simonhong · 2024-10-08T03:17:02Z

fix brave/brave-browser#41451
fix brave/brave-browser#41456

Resolves

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

See the linked issue
BraveTemplateURLPrepopulateDataTest.DefaultSearchProvidersForAustralia

fix brave/brave-browser#41451

deeppandya

LGTM

Set brave search as a default search provider in AU

brave-builds · 2024-10-09T12:03:30Z

Released in v1.72.75

LaurenWags · 2024-10-17T19:18:09Z

Verified with

Brave | 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (x86_64)
-- | --
Revision | 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS | macOS Version 14.7 (Build 23H124)

Australia (AU) locale - New Brave Search default region

Clean Profile - PASSED

ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Brave was selected as the default via brave://settings/searchEngines

`Example`	`Example`	`Example`	`Example`	`Example`

Updated Profile (Google/Brave) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
ensured that Google was the default SE selected under brave://settings/search for Normal windows
ensured that Brave was the default SE selected under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58 and ensured that Google is still the default SE for Normal windows
ensured that Brave is still the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Updated Profile (DDG/Startpage) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
changed the default SE to DDG under brave://settings/search for Normal windows
changed the default SE to Startpage under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that DDG wasn't replaced with Brave as the default SE for Normal windows
ensured that Startpage wasn't replaced with Brave as the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

United States (US) locale - Existing Brave Search default region

Clean Profile - PASSED

ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Brave was selected as the default via brave://settings/searchEngines

`Example`	`Example`	`Example`	`Example`	`Example`

Updated Profile (Brave/Brave) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
ensured that Brave was the default SE selected under brave://settings/search for Normal windows
ensured that Brave was the default SE selected under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Brave is still the default SE for both Normal & Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Updated Profile (Ecosia/Bing) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
changed the default SE to Ecosia under brave://settings/search for Normal windows
changed the default SE to Bing under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Ecosia wasn't replaced with Brave as the default SE for Normal windows
ensured that Bing wasn't replaced with Brave as the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Italy (IT) locale - Existing Brave Search default region

Clean Profile - PASSED

ensured that Brave was selected as the default for both Normal/Private windows via brave://settings/search
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Brave was selected as the default via brave://settings/searchEngines

`Example`	`Example`	`Example`	`Example`	`Example`

Updated Profile (Brave/Brave) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
ensured that Brave was the default SE selected under brave://settings/search for Normal windows
ensured that Brave was the default SE selected under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Brave is still the default SE for both Normal & Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Updated Profile (Qwant/DDG) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
changed the default SE to Qwant under brave://settings/search for Normal windows
changed the default SE to DDG under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Qwant wasn't replaced with Brave as the default SE for Normal windows
ensured that DDG wasn't replaced with Brave as the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal` windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Aruba (AW) locale - Non Brave Search default region (Google is default SE)

Clean Profile - PASSED

ensured that Google was selected as the default for Normal windows via brave://settings/search
ensured that Brave was selected as the default for Private windows via brave://settings/search
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows
ensured that Google was selected as the default via brave://settings/searchEngines
ensured that Brave was listed first via brave://settings/searchEngines

`Example`	`Example`	`Example`	`Example`	`Example`

Updated Profile (Google/Brave) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
ensured that Google was the default SE selected under brave://settings/search for Normal windows
ensured that Brave was the default SE selected under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58 and ensured that Google is still the default SE for Normal windows
ensured that Brave is still the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal underbrave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Updated Profile (Startpage/Google) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
changed the default SE to Startpage under brave://settings/search for Normal windows
changed the default SE to Google under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Startpage wasn't replaced with Brave as the default SE for Normal windows
ensured that Google wasn't replaced with Brave as the default SE for Private windows
ensured that Brave was the first engine via the "Change" modal under brave://settings/search for Normal windows
ensured that Brave was the first engine via the drop down list under brave://settings/search for Private windows

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Russia (RU) locale - Non Brave Search default region (Yandex is default SE)

Clean Profile - PASSED

ensured that Yandex was selected as the default for Normal windows via brave://settings/search
ensured that Brave was selected as the default for Private windows via brave://settings/search
ensured that Brave was the second engine via the "Change" modal under brave://settings/search for Normal windows (Yandex is first)
ensured that Brave was the second engine via the drop down list under brave://settings/search for Private windows (Yandex is first)
ensured that Yandex was selected as the default via brave://settings/searchEngines
ensured that Brave was listed second via brave://settings/searchEngines (Yandex is first)

`Example`	`Example`	`Example`	`Example`	`Example`

Updated Profile (Yandex/Brave) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
ensured that Yandex was the default SE selected under brave://settings/search for Normal windows
ensured that Brave was the default SE selected under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58 and ensured that Yandex is still the default SE for Normal windows
ensured that Brave is still the default SE for Private windows
ensured that Brave was the second engine via the "Change" modal underbrave://settings/search for Normal windows (Yandex is first)
ensured that Brave was the second engine via the drop down list under brave://settings/search for Private windows (Yandex is first)

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

Updated Profile (Bing/Startpage) - PASSED

installed 1.71.114 Chromium: 130.0.6723.58
changed the default SE to Bing under brave://settings/search for Normal windows
changed the default SE to Startpage under brave://settings/search for Private windows
updated to 1.72.82 Chromium: 130.0.6723.58
ensured that Bing wasn't replaced with Brave as the default SE for Normal windows
ensured that Startpage wasn't replaced with Brave as the default SE for Private windows
ensured that Brave was the second engine via the "Change" modal under brave://settings/search for Normal windows (Yandex is first)
ensured that Brave was the second engine via the drop down list under brave://settings/search for Private windows (Yandex is first)

`1.71.114 Chromium: 130.0.6723.58`	`1.72.82 Chromium: 130.0.6723.58`

kjozwiak · 2024-10-21T02:36:55Z

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.73.26 Chromium: 130.0.6723.58 (Official Build) canary (64-bit)
--- | ---
Revision | a0cca7c24817bbc2832897acfbd713d496b2b2a1
OS | Android 15; Build/AP41.240823.009; 35; REL

`Australia (AU) locale` - `PASSED`

Clean Profile

ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`Example`	`Example`	`Example`

Updated Profile (Google/Google)

installed 1.72.73 Chromium: 130.0.6723.31
ensured that Google was the default SE selected under Settings -> Search engines for Standard Tab
ensured that Google was the default SE selected under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58 and ensured that Google is still the default for Standard & Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

Updated Profile (DDG/Qwant)

installed 1.72.73 Chromium: 130.0.6723.31
changed the default SE to DDG under Settings -> Search engines for Standard Tab
changed the default SE to Qwant under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58
ensured that DDG wasn't replaced with Brave as the default SE for Standard Tab
ensured that Qwant wasn't replaced with Brave as the default SE for Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

`DE (Germany) locale` - `PASSED`

Clean Profile

ensured that Brave was selected as the default for both Normal/Private windows via Settings -> Search engines
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`Example`	`Example`	`Example`

Updated Profile (Brave/Brave)

installed 1.72.73 Chromium: 130.0.6723.31
ensured that Brave was the default SE selected under Settings -> Search engines for Standard Tab
ensured that Brave was the default SE selected under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58
ensured that Brave is still the default SE for both Standard Tab & Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

Updated Profile (Qwant/Bing)

installed 1.72.73 Chromium: 130.0.6723.31
changed the default SE to Qwant under Settings -> Search engines for Standard Tab
changed the default SE to Bing under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58
ensured that Qwant wasn't replaced with Brave as the default SE for Standard Tab
ensured that Bing wasn't replaced with Brave as the default SE for Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

`RO (Rromania) locale` - `PASSED`

Clean Profile

ensured that Google was selected as the default for both Normal/Private windows via Settings -> Search engines
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`Example`	`Example`	`Example`

Updated Profile (Google/Google)

installed 1.72.73 Chromium: 130.0.6723.31
ensured that Google was the default SE selected under Settings -> Search engines for Standard Tab
ensured that Google was the default SE selected under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58
ensured that Google is still the default SE for both Standard Tab & Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

Updated Profile (Startpage/DDG)

installed 1.72.73 Chromium: 130.0.6723.31
changed the default SE to Startpage under Settings -> Search engines for Standard Tab
changed the default SE to DDG under Settings -> Search engines for Private Tab
updated to 1.73.26 Chromium: 130.0.6723.58
ensured that Startpage wasn't replaced with Brave as the default SE for Standard Tab
ensured that DDG wasn't replaced with Brave as the default SE for Private Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Standard Tab
ensured that Brave was the first engine via the drop down list under Settings -> Search engines for Private Tab

`1.72.73 Chromium: 130.0.6723.31`	`1.73.26 Chromium: 130.0.6723.58`

#25899) Merge pull request #25870 from brave/set_brave_search_as_default_au Set brave search as a default search provider in AU

simonhong self-assigned this Oct 8, 2024

Set brave search as a default search provider in AU

1f3f641

fix brave/brave-browser#41451

simonhong force-pushed the set_brave_search_as_default_au branch from fb78fd5 to 1f3f641 Compare October 8, 2024 04:26

simonhong requested review from bsclifton and deeppandya and removed request for bsclifton October 8, 2024 06:03

simonhong marked this pull request as ready for review October 8, 2024 06:04

simonhong requested a review from a team as a code owner October 8, 2024 06:04

emerick approved these changes Oct 8, 2024

View reviewed changes

deeppandya approved these changes Oct 8, 2024

View reviewed changes

simonhong merged commit 021087e into master Oct 9, 2024
17 checks passed

simonhong deleted the set_brave_search_as_default_au branch October 9, 2024 00:54

github-actions bot added this to the 1.72.x - Nightly milestone Oct 9, 2024

simonhong added a commit that referenced this pull request Oct 9, 2024

Merge pull request #25870 from brave/set_brave_search_as_default_au

7e48784

Set brave search as a default search provider in AU

simonhong mentioned this pull request Oct 9, 2024

Set brave search as a default search provider in AU (uplift to 1.71.x) #25899

Merged

7 tasks

kjozwiak pushed a commit that referenced this pull request Oct 21, 2024

Set brave search as a default search provider in AU (uplift to 1.71.x) (

ddb3728

#25899) Merge pull request #25870 from brave/set_brave_search_as_default_au Set brave search as a default search provider in AU

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set brave search as a default search provider in AU #25870

Set brave search as a default search provider in AU #25870

simonhong commented Oct 8, 2024 •

edited

Loading

deeppandya left a comment

brave-builds commented Oct 9, 2024

LaurenWags commented Oct 17, 2024 •

edited

Loading

kjozwiak commented Oct 21, 2024

Set brave search as a default search provider in AU #25870

Set brave search as a default search provider in AU #25870

Conversation

simonhong commented Oct 8, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

deeppandya left a comment

Choose a reason for hiding this comment

brave-builds commented Oct 9, 2024

LaurenWags commented Oct 17, 2024 • edited Loading

Australia (AU) locale - New Brave Search default region

United States (US) locale - Existing Brave Search default region

Italy (IT) locale - Existing Brave Search default region

Aruba (AW) locale - Non Brave Search default region (Google is default SE)

Russia (RU) locale - Non Brave Search default region (Yandex is default SE)

kjozwiak commented Oct 21, 2024

Australia (AU) locale - PASSED

DE (Germany) locale - PASSED

RO (Rromania) locale - PASSED

simonhong commented Oct 8, 2024 •

edited

Loading

LaurenWags commented Oct 17, 2024 •

edited

Loading

`Australia (AU) locale` - `PASSED`

`DE (Germany) locale` - `PASSED`

`RO (Rromania) locale` - `PASSED`