Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable safebrowsing download protection #4341

Closed
diracdeltas opened this issue May 8, 2019 · 8 comments · Fixed by brave/brave-core#2710
Closed

Disable safebrowsing download protection #4341

diracdeltas opened this issue May 8, 2019 · 8 comments · Fixed by brave/brave-core#2710

Comments

@diracdeltas
Copy link
Member

Safebrowsing download protection (not browsing protection) should be disabled until we find a way to prevent it from sending URLs to a remote service.

See https://feeding.cloud.geek.nz/posts/how-safe-browsing-works-in-firefox/ for instance

@diracdeltas
Copy link
Member Author

Related: #4335 (for just Tor, not normal mode)

@tildelowengrimm tildelowengrimm added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 8, 2019
@diracdeltas
Copy link
Member Author

cc @fmarier

@fmarier fmarier self-assigned this May 21, 2019
@fmarier
Copy link
Member

fmarier commented Jun 15, 2019

Test plan is the first part of what is mentioned in the PR:

To test that remote lookups are no longer done, go to https://testsafebrowsing.appspot.com and verify that none of the Download Warnings files get blocked.

The second part can't really be tested without making a custom build :(

fmarier added a commit to brave/brave-core that referenced this issue Sep 21, 2019
This also disables download protection remote lookups, which
fixes brave/brave-browser#4341.
fmarier added a commit to brave/brave-core that referenced this issue Oct 2, 2019
This also temporarily disables download protection remote lookups,
which fixes brave/brave-browser#4341.
fmarier added a commit to brave/brave-core that referenced this issue Oct 3, 2019
@fmarier fmarier added this to the 0.72.x - Nightly milestone Oct 4, 2019
@btlechowski
Copy link

@fmarier https://testsafebrosing.appspot.com/ gives me 404. The test plan needs to be updated.

@tildelowengrimm
Copy link
Contributor

@btlechowski https://testsafebrowsing.appspot.com works fine for me.

@fmarier
Copy link
Member

fmarier commented Oct 30, 2019

Sorry for the typo, I've fixed it in #4341 (comment).

@btlechowski
Copy link

Works now, I didn't notice the typo.

@btlechowski
Copy link

btlechowski commented Oct 30, 2019

Verification passed on

Brave 0.72.112 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified test plan based on #4341 (comment)

image

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan based on #4341 (comment)
image

Verified passed with

Brave 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-11-19 at 12 31 42 PM

Screen Shot 2019-11-19 at 12 32 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants