Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging sites to stdout on exit #4420

Closed
jumde opened this issue May 13, 2019 · 2 comments · Fixed by brave/brave-core#2436
Closed

Stop logging sites to stdout on exit #4420

jumde opened this issue May 13, 2019 · 2 comments · Fixed by brave/brave-core#2436

Comments

@jumde
Copy link
Contributor

jumde commented May 13, 2019

https://github.com/brave/brave-core/blob/ac766becf4eadaa53a90ba897781878c8a71db82/vendor/bat-native-ledger/src/bat/ledger/internal/media/twitch.cc#L181

Logs all sites visited by user to stdout.

Repro Steps:

  1. Open Brave Browser using terminal (/Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly)
  2. Navigate to any site and see that logs of the URL you visited will be printed on the console

Test Plan

Specified here: brave/brave-core#2435

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X
  • reproduced the original issue using 0.65.89 Chromium: 74.0.3729.131
  • ensured websites are not being logged in terminal when visited when using normal tabs
  • ensured websites are not being logged in terminal when visited when using Tor
  • ensured websites are not being logged in terminal when visited when using PB
  • ensured websites are not being logged in terminal when visited when using Guest mode

@srirambv
Copy link
Contributor

srirambv commented May 29, 2019

Verification passed on

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
  • Verified no site info is logged in normal/private/Tor windows

Verification passed on

Brave 0.65.114 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.765)
  • Verified no site info is logged in normal/private/Tor windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment