Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut is not working on Windows #4654

Closed
simonhong opened this issue May 30, 2019 · 1 comment · Fixed by brave/brave-core#2544
Closed

Shortcut is not working on Windows #4654

simonhong opened this issue May 30, 2019 · 1 comment · Fixed by brave/brave-core#2544
Assignees
@simonhong
Labels
OS/Windows QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.66.x - Release ...

Comments

@simonhong
Copy link
Member

Shortcuts created by app menu (Move Tools -> Create Shortcut...) doesn't start application.

#3750 is original issue that reported this error.
Created this issue for easier PR managing because macos also has same issue but each one will be handled by separate PRs.
@simonhong simonhong added this to the 0.68.x - Nightly milestone May 30, 2019
@simonhong simonhong self-assigned this May 30, 2019
@simonhong simonhong mentioned this issue May 30, 2019
Merged
29 tasks
@simonhong simonhong mentioned this issue May 31, 2019
Closed
@btlechowski
Copy link

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

Used test plan from brave/brave-core#2544. Created shortcuts for different domains.

@LaurenWags LaurenWags mentioned this issue Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Windows QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.66.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Make shortcut work on Windows brave/brave-core
3 participants
@kjozwiak @simonhong @btlechowski