Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shortcut work on Windows #2544

Merged
merged 1 commit into from
May 30, 2019
Merged

Make shortcut work on Windows #2544

merged 1 commit into from
May 30, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 30, 2019

When shortcut is created on Windows, it runs chrome_proxy.exe.
Then it runs chrome.exe. This makes shortcut doesn't work because
chrome.exe is renamed to brave.exe.

Fix brave/brave-browser#4654

Submitter Checklist:

Test Plan:

  1. build installer by yarn create_dist Release --skip_signing
  2. install it by brave_installer.exe
  3. launch brave and create shortcut from app menu
  4. db click the shortcut

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

When shortcut is created on Windows, it runs chrome_proxy.exe.
Then it runs chrome.exe. This makes shortcut doesn't work because
chrome.exe is renamed to brave.exe.
@simonhong simonhong added this to the 0.68.x - Nightly milestone May 30, 2019
@simonhong simonhong self-assigned this May 30, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shortcut is not working on Windows
4 participants