Make shortcut work on Windows (uplift to 0.67.x) #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
kjozwiak
approved these changes
May 31, 2019
There was a problem hiding this comment.
Uplift to 0.67.x approved after deliberating with @brave/uplift-approvers. I reproduced the original issue using 0.68.4 and verified that it's working using 0.68.5 CR: 75.0.3770.38.
Test Cases used:
- ensured that
More tools-->Create shortcutworked on several different websites - ensured that the shortcuts added on the desktop opened either a new tab or new window
- ensured that the shortcuts can be opened when
nightlyisn't currently running - ensured that the shortcuts can be opened while
nightlyis currently running - ensured that you can uninstall the
AppsviaUninstalland ensured the shortcuts are removed from theDesktop&C:\Users\kamil\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Brave Apps
Please ensure that all the correct labels are being used and that the associated issue(s) are moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #2544
Approved, please ensure that before merging:
After you merge: