Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined symbol link error for translate feature on windows release build #4656

Closed
yrliou opened this issue May 31, 2019 · 1 comment · Fixed by brave/brave-core#2557
Closed

Comments

@yrliou
Copy link
Member

yrliou commented May 31, 2019

Link error caused by brave/brave-core#2542 on windows release channel official build.

20:15:39 FAILED: chrome_child.dll chrome_child.dll.lib chrome_child.dll.pdb 
20:15:39 ninja -t msvc -e environment.x86 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./chrome_child.dll.lib /DLL /OUT:./chrome_child.dll /PDB:./chrome_child.dll.pdb @./chrome_child.dll.rsp
20:15:39 lld-link: error: undefined symbol: "struct base::Feature const translate::kTranslateUI" (?kTranslateUI@translate@@3UFeature@base@@B)
20:15:39 >>> referenced by .\..\..\brave\app\brave_main_delegate.cc:145
20:15:39 >>>               obj/chrome/chrome_child/chrome_main_delegate.obj:("protected: virtual bool __thiscall BraveMainDelegate::BasicStartupComplete(int *)" (?BasicStartupComplete@BraveMainDelegate@@MAE_NPAH@Z))
20:15:41 [508/736] LINK setup.exe setup.exe.pdb
20:15:43 [509/736] LINK chromedriver.exe chromedriver.exe.pdb
20:15:43 ninja: build stopped: subcommand failed.
@yrliou
Copy link
Member Author

yrliou commented May 31, 2019

This would happen only in official build & release channel on win because of chrome's multi dll stuff in https://cs.chromium.org/chromium/src/chrome/BUILD.gn, can be reproduced in my local win by running npm run build Release --channel=release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment