-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable in-page translation in release channel #2542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor nit.
#include "brave/browser/translate/buildflags/buildflags.h" | ||
|
||
namespace { | ||
bool IsBraveTranslateEnable() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really minor nitpick, but should it be called IsBraveTranslateEnabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Locally went through the test plan on mac by building both development&debug build and stable&official build, and on windows & linux by changing the value of is_release_channel. |
…bble and context menu item.
ea1dcfc
to
8ed9296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Disable in-page translation in release channel
Disable in-page translation in release channel
Disable in-page translation in release channel
Fix brave/brave-browser#4626
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Translate to English
(or any other default language) shouldn't be shown in release channel but will be shown in any other channels.Offer to translate pages that aren't in a language you read
switch should not be shown in release channel but will be shown in any other channels.Reviewer Checklist:
After-merge Checklist:
changes has landed on.