Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a feature flag for enabling translation #4626

Closed
rebron opened this issue May 28, 2019 · 2 comments · Fixed by brave/brave-core#2542
Closed

add a feature flag for enabling translation #4626

rebron opened this issue May 28, 2019 · 2 comments · Fixed by brave/brave-core#2542

Comments

@rebron
Copy link
Collaborator

rebron commented May 28, 2019

Test Plan

Description

Add a feature flag for enabling translation service. Translation prompt/icon should not show in the url bar and translation context menu "Translate to 'language'" should not appear.

Feature flag for translation should be enabled for beta/dev/nightly channel.
Feature flag for translation should be disabled for release channel.

Brave version (brave://version info)

Feature flag should be disabled for release channel starting with 65.x.

@kjozwiak
Copy link
Member

kjozwiak commented May 31, 2019

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.115 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Screen Shot 2019-05-31 at 2 11 19 AM

  • 0.68.5 Chromium: 75.0.3770.38 & 0.66.80 Chromium: 75.0.3770.38 Example:

Screen Shot 2019-05-31 at 2 11 26 AM

Screen Shot 2019-05-31 at 2 14 12 AM

Verification passed on

Brave 0.65.116 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

@srirambv
Copy link
Contributor

srirambv commented May 31, 2019

Verification passed on

Brave 0.65.116 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment