Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift Disable in-page translation in release channel to 0.67.x #2546

Merged
merged 1 commit into from
May 30, 2019
Merged

Uplift Disable in-page translation in release channel to 0.67.x #2546

merged 1 commit into from
May 30, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented May 30, 2019 •
edited
Loading

Disable in-page translation in release channel
Uplift of #2542
Issue: brave/brave-browser#4626

@yrliou
Merge pull request #2542 from brave/disable_translate_in_release
39188d3 
Disable in-page translation in release channel
@yrliou yrliou self-assigned this May 30, 2019
@yrliou yrliou added this to the 0.67.x - Dev milestone May 30, 2019
@yrliou yrliou requested a review from a team May 30, 2019 18:00
@yrliou
Copy link
Member Author

yrliou commented May 30, 2019

PR builder only failed at Publish xUnit test result report in window-x64's test-unit step, but the tests were run successfully, seems not likely a problem of this PR.

kjozwiak
kjozwiak approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.67.x approved as per our earlier group conversation in the weekly b-c triage meeting. Please make sure that all the correct labels are being used and the appropriate issue(s) are moved into the correct milestone.

@yrliou yrliou merged commit 6ee5107 into 0.67.x May 30, 2019
@yrliou yrliou deleted the disable_translate_in_release_0.67.x branch May 30, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @kjozwiak