Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields: Add Default view option in settings for simple and advanced views #4784

Closed
tildelowengrimm opened this issue Jun 10, 2019 · 2 comments · Fixed by brave/brave-core#2973
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Jun 10, 2019

Description

Allow users to set their global default view of the Shields panel. Follow-up to #1196.

Designs

Surface an option in Shields settings to set the global default view of Shields:

shields settings default view

The global default view applies to any site the user has not previously clicked to switch views (that count as a site-specific customization and will be retained). Turning on or off Shields does not affect the site-specific view.

user flows - simple and advanced global customization

Assets available in this zipped folder: assets.zip
SVG assets : svg assets.zip

Test plan

Settings --> Shields

  1. Go to brave://settings/shields

  2. Select Simple View

  3. Go to a website

  4. Open Shields
    --> Expected: Chceck shields view is Simple

  5. Go to brave://settings/shields again

  6. Select Advanced View

  7. Go to a website

  8. Open shields
    --> Expected: Chceck shields view is Advanced (larger)

Shields --> Settings

  1. Clean profile

  2. Go to a website

  3. Open shields
    --> Expected: Shields opens in Simple view (clean profile defaults to "simple")

  4. Toggle option to "Advanced view" inside shields popup

  5. Visit brave://settings/shields in another window or tab
    --> Expected: "Default view" has 'Advanced view' selected

  6. Visit website again

  7. Open Shields

  8. Click 'Simple View' inside shields popup

  9. Switch back to Settings tab / window
    --> Expected: "Default view" has 'Simple view' selected

@tildelowengrimm tildelowengrimm added feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jun 10, 2019
@karenkliu karenkliu changed the title Settings change to pick between Shields simple and advanced view Set Shields simple and advanced view as global default in Settings Jun 13, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 14, 2019
@cezaraugusto cezaraugusto removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jul 15, 2019
@kjozwiak kjozwiak added this to the 0.70.x - Nightly milestone Aug 2, 2019
@bsclifton bsclifton modified the milestones: 0.70.x - Dev, 0.69.x - Beta Aug 28, 2019
@bsclifton
Copy link
Member

Added QA/Yes and other labels after uplift to 0.69.x 👍

@btlechowski
Copy link

btlechowski commented Sep 3, 2019

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verification passed in

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

@rebron rebron changed the title Set Shields simple and advanced view as global default in Settings Shields - Add Default view option in settings for simple and advanced views Oct 2, 2019
@rebron rebron changed the title Shields - Add Default view option in settings for simple and advanced views Shields: Add Default view option in settings for simple and advanced views Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants