-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields: Add Default view option in settings for simple and advanced views #4784
Labels
feature/global-settings
Settings at browser level independent of shields settings
feature/shields
The overall Shields feature in Brave.
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
tildelowengrimm
added
feature/shields
The overall Shields feature in Brave.
feature/global-settings
Settings at browser level independent of shields settings
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
labels
Jun 10, 2019
karenkliu
changed the title
Settings change to pick between Shields simple and advanced view
Set Shields simple and advanced view as global default in Settings
Jun 13, 2019
tildelowengrimm
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Jun 14, 2019
cezaraugusto
removed
the
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
label
Jul 15, 2019
6 tasks
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
Jul 24, 2019
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 30, 2019
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Aug 1, 2019
Added |
Verification passed on
Verification passed in
Verified passed with
|
rebron
changed the title
Set Shields simple and advanced view as global default in Settings
Shields - Add Default view option in settings for simple and advanced views
Oct 2, 2019
rebron
changed the title
Shields - Add Default view option in settings for simple and advanced views
Shields: Add Default view option in settings for simple and advanced views
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/global-settings
Settings at browser level independent of shields settings
feature/shields
The overall Shields feature in Brave.
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
Allow users to set their global default view of the Shields panel. Follow-up to #1196.
Designs
Surface an option in Shields settings to set the global default view of Shields:
The global default view applies to any site the user has not previously clicked to switch views (that count as a site-specific customization and will be retained). Turning on or off Shields does not affect the site-specific view.
Assets available in this zipped folder: assets.zip
SVG assets : svg assets.zip
Test plan
Settings --> Shields
Go to
brave://settings/shields
Select Simple View
Go to a website
Open Shields
--> Expected: Chceck shields view is Simple
Go to
brave://settings/shields
againSelect Advanced View
Go to a website
Open shields
--> Expected: Chceck shields view is Advanced (larger)
Shields --> Settings
Clean profile
Go to a website
Open shields
--> Expected: Shields opens in Simple view (clean profile defaults to "simple")
Toggle option to "Advanced view" inside shields popup
Visit
brave://settings/shields
in another window or tab--> Expected: "Default view" has 'Advanced view' selected
Visit website again
Open Shields
Click 'Simple View' inside shields popup
Switch back to Settings tab / window
--> Expected: "Default view" has 'Simple view' selected
The text was updated successfully, but these errors were encountered: