Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show the same ad more than once every hour #5281

Closed
jsecretan opened this issue Jul 18, 2019 · 3 comments · Fixed by brave/brave-core#3296
Closed

Do not show the same ad more than once every hour #5281

jsecretan opened this issue Jul 18, 2019 · 3 comments · Fixed by brave/brave-core#3296
Assignees
@tmancey
Labels
enhancement feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
0.70.x - Release

Comments

@jsecretan
Copy link

Description

Even though we now have the capability for user level frequency capping, and there are coming improvements to evening out the pacing of ad delivery, there can still be cases where either limited inventory in certain categories can make it feel like ads are repeated too often. To help this, I am proposing that we limit repeating a campaign id to no more than once an hour. This is not a setting transmitted in the catalog, but a hard coded browser setting.
@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 18, 2019
@tmancey tmancey removed their assignment Aug 22, 2019
@tmancey tmancey mentioned this issue Aug 29, 2019
Merged
32 tasks
@tmancey tmancey self-assigned this Sep 2, 2019
@tmancey tmancey added this to the 0.71.x - Nightly milestone Sep 2, 2019
tmancey added a commit to brave/brave-core that referenced this issue Sep 3, 2019
@tmancey
Do not show the same ad more than once every hour
5e7b4fa 
Fixes brave/brave-browser#5281
@tmancey tmancey added the QA/Yes label Sep 4, 2019
@LaurenWags
Copy link
Member

Confirmed with @srirambv that this was tested on mobile. Only desktop needs to be tested by QA.

@LaurenWags
Copy link
Member

Still seeing ads for same campaign_id in the same hour. Will work with @tmancey when he's available. Marking as QA/Blocked until that is sorted.

@LaurenWags LaurenWags mentioned this issue Oct 11, 2019
Closed
@LaurenWags
Copy link
Member

Per discussion in Slack, changing this to QA/No and release-notes/exclude since I'm still getting the same ad twice in a row. Per discussion with @tmancey this is most likely related to #4207.

I have logged a follow up issue #6447 and have a profile/logs which I can share if they'd be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Do not show the same ad more than once every hour brave/brave-core
4 participants
@jsecretan @tmancey @kjozwiak @LaurenWags