Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of publisher list db #5907

Closed
NejcZdovc opened this issue Sep 5, 2019 · 1 comment · Fixed by brave/brave-core#3369
Closed

Optimization of publisher list db #5907

NejcZdovc opened this issue Sep 5, 2019 · 1 comment · Fixed by brave/brave-core#3369
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

  1. make sure that banner is only populated if something is in it (right now we save empty rows)
  2. after wallet is initialized we call download again (we should call it only once)
@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Sep 5, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Release milestone Sep 5, 2019
@NejcZdovc NejcZdovc self-assigned this Sep 5, 2019
@NejcZdovc NejcZdovc mentioned this issue Sep 5, 2019
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 5, 2019
@NejcZdovc
Fixes publisher banner being empty in the db
8cd8bb9 
Resolves brave/brave-browser#5907
@LaurenWags
Copy link
Member

LaurenWags commented Sep 9, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verified, KYC'd publishers with custom banners:
Screen Shot 2019-09-09 at 5 24 28 PM
Screen Shot 2019-09-09 at 5 24 52 PM

Connected, no KYC publishers with custom banners:
Screen Shot 2019-09-09 at 5 23 38 PM
Screen Shot 2019-09-09 at 5 24 02 PM
Screen Shot 2019-09-09 at 5 26 17 PM

Unverified publisher, no custom banner:
Screen Shot 2019-09-09 at 5 25 07 PM

Verification passed on

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified, KYC'd publisher with custom banners:
image

Verified, KYC'd publisher with default banners:
image

Connected, no KYC publishers with custom banners:
image

Connected, no KYC publishers with default banners:
image

Unverified publisher, no custom banner:
image

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified, KYC'd publishers with custom banners:

image

Connected, no KYC publishers with custom banners:
image

image

Unverified publisher, no custom banner:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Db optimizations brave/brave-core
5 participants
@bsclifton @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya